Bug 1994063 - Review Request: nginx-mod-naxsi - nginx web application firewall module
Summary: Review Request: nginx-mod-naxsi - nginx web application firewall module
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-08-16 15:56 UTC by Neal Gompa
Modified: 2021-08-26 21:10 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-08-26 21:07:33 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Neal Gompa 2021-08-16 15:56:47 UTC
Spec URL: https://ngompa.fedorapeople.org/for-review/nginx-mod-naxsi.spec
SRPM URL: https://ngompa.fedorapeople.org/for-review/nginx-mod-naxsi-1.3-1.fc34.src.rpm

Description:
naxsi is an nginx module that provides score based Web Application Firewall
(WAF) abilities in a highly granular fashion.

Fedora Account System Username: ngompa

Comment 1 Davide Cavalca 2021-08-16 16:04:24 UTC
- build fails due to missing nginx-mod-devel
- use install -p to preserve timestamps

Comment 2 Davide Cavalca 2021-08-16 16:09:09 UTC
Ok looks like I can get this further in mock with --enablerepo local, but the build fails at the end with:

Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.orW5vF
+ umask 022
+ cd /builddir/build/BUILD
+ '[' /builddir/build/BUILDROOT/nginx-mod-naxsi-1.3-1.fc36.x86_64 '!=' / ']'
+ rm -rf /builddir/build/BUILDROOT/nginx-mod-naxsi-1.3-1.fc36.x86_64
++ dirname /builddir/build/BUILDROOT/nginx-mod-naxsi-1.3-1.fc36.x86_64
+ mkdir -p /builddir/build/BUILDROOT
+ mkdir /builddir/build/BUILDROOT/nginx-mod-naxsi-1.3-1.fc36.x86_64
+ cd naxsi-1.3
~/build/BUILD/naxsi-1.3/naxsi_src/redhat-linux-build ~/build/BUILD/naxsi-1.3
+ pushd naxsi_src/redhat-linux-build
+ install -dm 0755 /builddir/build/BUILDROOT/nginx-mod-naxsi-1.3-1.fc36.x86_64/usr/lib64/nginx/modules
+ install -m0755 ngx_http_naxsi_module.so /builddir/build/BUILDROOT/nginx-mod-naxsi-1.3-1.fc36.x86_64/usr/lib64/nginx/modules
+ popd
~/build/BUILD/naxsi-1.3
+ install -dm 0755 /builddir/build/BUILDROOT/nginx-mod-naxsi-1.3-1.fc36.x86_64/usr/share/nginx/modules
+ echo 'load_module "/usr/lib64/nginx/modules/ngx_http_naxsi_module.so";'
+ popd
/var/tmp/rpm-tmp.orW5vF: line 45: popd: directory stack empty

RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.orW5vF (%install)
    Bad exit status from /var/tmp/rpm-tmp.orW5vF (%install)

Comment 3 Neal Gompa 2021-08-16 16:14:07 UTC
Looks like I goofed when I cleaned up the pushd/popd stuff. I've fixed that and updated the packages linked in the initial comment.

Comment 4 Davide Cavalca 2021-08-16 16:17:49 UTC
You're still missing an install -p for the .so. Beyond that:

- Packaging follows naming guidelines
- Package licensing is indicated correctly
- Packaging builds and installs (when dependencies are installed and pre-populated in the chroot)
- No serious issues from rpmlint

PACKAGE APPROVED.

Comment 5 Gwyn Ciesla 2021-08-16 16:37:36 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nginx-mod-naxsi

Comment 6 Fedora Update System 2021-08-18 05:31:26 UTC
FEDORA-2021-9ba7f42344 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-9ba7f42344

Comment 7 Fedora Update System 2021-08-18 05:31:27 UTC
FEDORA-2021-363146d5cc has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-363146d5cc

Comment 8 Fedora Update System 2021-08-19 01:42:15 UTC
FEDORA-2021-363146d5cc has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-363146d5cc \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-363146d5cc

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-08-19 01:51:58 UTC
FEDORA-2021-9ba7f42344 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-9ba7f42344 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-9ba7f42344

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2021-08-26 21:07:33 UTC
FEDORA-2021-363146d5cc has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2021-08-26 21:10:05 UTC
FEDORA-2021-9ba7f42344 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.