Bug 1994117

Summary: Some hardcodes are detected at the code level in orphaned code
Product: OpenShift Container Platform Reporter: Robb Hamilton <rhamilto>
Component: Management ConsoleAssignee: Robb Hamilton <rhamilto>
Status: CLOSED ERRATA QA Contact: Xiyun Zhao <xiyuzhao>
Severity: low Docs Contact:
Priority: unspecified    
Version: 4.8CC: jhadvig, kdoberst, spadgett, xurl, yapei
Target Milestone: ---Keywords: i18n, Translation
Target Release: 4.11.0   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: 1991439 Environment:
Last Closed: 2022-08-10 10:36:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Comment 1 Robb Hamilton 2021-08-16 19:16:17 UTC
The following files are obsolete and should be removed from the code base:
* frontend/public/components/alert-manager.tsx
* frontend/public/components/chargeback.tsx
* frontend/public/components/cluster-service-class.tsx
* frontend/public/components/instantiate-template.tsx
* frontend/public/components/prometheus.jsx
* frontend/public/components/service-binding.tsx
* frontend/public/components/service-instance.tsx

Note there may be related code that should also be removed at the same time.

Comment 4 Jakub Hadvig 2022-04-25 10:10:54 UTC
Looks like the status is change due to the closed PR.

Comment 5 Robb Hamilton 2022-04-26 12:36:45 UTC
These files are still in use and should *not* be removed:

* frontend/public/components/alert-manager.tsx
* frontend/public/components/instantiate-template.tsx

Comment 6 Robb Hamilton 2022-04-26 12:37:50 UTC
These files are still in use and should *not* be removed:

* frontend/public/components/alert-manager.tsx
* frontend/public/components/instantiate-template.tsx
* frontend/public/components/prometheus.jsx

Comment 10 Xiyun Zhao 2022-05-12 03:10:24 UTC
This bug has been verified on payload 4.11.0-0.nightly-2022-05-11-054135 and repo of console

The removed orphaned Service Catalog and Chargeback code could not find on the newest console repo, and console can be built successfully without any error. The remove function like service catalog will not impact the exiting function on UI. Move this bug to verified

Comment 12 errata-xmlrpc 2022-08-10 10:36:53 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069