Bug 1994117 - Some hardcodes are detected at the code level in orphaned code
Summary: Some hardcodes are detected at the code level in orphaned code
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.8
Hardware: All
OS: All
unspecified
low
Target Milestone: ---
: 4.11.0
Assignee: Robb Hamilton
QA Contact: Xiyun Zhao
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-08-16 19:13 UTC by Robb Hamilton
Modified: 2022-08-10 10:37 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of: 1991439
Environment:
Last Closed: 2022-08-10 10:36:53 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 11400 0 None open [WIP] Bug 1994117: remove orphaned Service Catalog and Chargeback code 2022-04-26 13:44:00 UTC
Red Hat Product Errata RHSA-2022:5069 0 None None None 2022-08-10 10:37:07 UTC

Comment 1 Robb Hamilton 2021-08-16 19:16:17 UTC 
The following files are obsolete and should be removed from the code base:
* frontend/public/components/alert-manager.tsx
* frontend/public/components/chargeback.tsx
* frontend/public/components/cluster-service-class.tsx
* frontend/public/components/instantiate-template.tsx
* frontend/public/components/prometheus.jsx
* frontend/public/components/service-binding.tsx
* frontend/public/components/service-instance.tsx

Note there may be related code that should also be removed at the same time.
Comment 4 Jakub Hadvig 2022-04-25 10:10:54 UTC 
Looks like the status is change due to the closed PR.
Comment 5 Robb Hamilton 2022-04-26 12:36:45 UTC 
These files are still in use and should *not* be removed:

* frontend/public/components/alert-manager.tsx
* frontend/public/components/instantiate-template.tsx
Comment 6 Robb Hamilton 2022-04-26 12:37:50 UTC 
These files are still in use and should *not* be removed:

* frontend/public/components/alert-manager.tsx
* frontend/public/components/instantiate-template.tsx
* frontend/public/components/prometheus.jsx
Comment 10 Xiyun Zhao 2022-05-12 03:10:24 UTC 
This bug has been verified on payload 4.11.0-0.nightly-2022-05-11-054135 and repo of console

The removed orphaned Service Catalog and Chargeback code could not find on the newest console repo, and console can be built successfully without any error. The remove function like service catalog will not impact the exiting function on UI. Move this bug to verified
Comment 12 errata-xmlrpc 2022-08-10 10:36:53 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069
Note You need to log in before you can comment on or make changes to this bug.