Bug 1994234
| Summary: | Review Request: rust-escape_string - Very efficiently parse backslash-escaped strings | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-07-06 20:15:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Davide Cavalca
2021-08-17 05:34:25 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=73990604 The BSD-2-Clause license requires redistributed sources to contain a copy of the license text. This is not the case here, the crate is published without a LICENSE file. Please report this issue upstream (while this crate is old, upstream is still active). Adding a symlink to the LICENSE file that sits at the root of the project's GitHub repo should be enough to make "cargo publish" include the LICENSE file next time they publish a version for escape_string. In the meantime, you could include that LICENSE file as a second source file, since it is obvious that it is the file that should apply to this (sub-)project too. Oh, and please re-generate the .spec file with rust2rpm 20. Put up https://github.com/njaard/sonnerie/pull/14 to get the license sorted out upstream. I don't know what happened, the pull request was closed as "Merged", but the change does not show up in the master branch. Maybe the developer accidentally force-pushed changes that overwrote your changes from the PR? Maybe it'd be easier to just include the license file as SOURCE1 until this is resolved upstream? Also should be re-generated with rust2rpm-21 now. Not sure what happened either, but I've commented on the original PR and added LICENSE as an extra Source for now. Spec URL: https://dcavalca.fedorapeople.org/review/rust-escape_string/rust-escape_string.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-escape_string/rust-escape_string-0.1.2-1.fc37.src.rpm Changelog: - rerun rust2rpm - update to 0.1.2 - add missing LICENSE + package name is OK
+ license is acceptable for Fedora (BSD)
+ license is specified correctly
+ latest version
+ builds and installs OK
+ latest rust2rpm was used
Hmm,the license file is now listed twice. Please change
- %license LICENSE
+ %license %{crate_instdir}/LICENSE
(That'll generate a warning about the file being listed twice, but that's a known issue.)
With that change, rpmlint only says: no-documentation, strange-permission,
which are both irrelevant.
Package is APPROVED.
Thanks! I'll fix the LICENSE thing on import. $ fedpkg request-repo rust-escape_string 1994234 https://pagure.io/releng/fedora-scm-requests/issue/45513 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-escape_string FEDORA-2022-8faf7bbb7e has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8faf7bbb7e FEDORA-2022-8faf7bbb7e has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-6de15e8f0f has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-6de15e8f0f FEDORA-2022-49275a02f9 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-49275a02f9 FEDORA-2022-6de15e8f0f has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-6de15e8f0f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-6de15e8f0f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-49275a02f9 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-49275a02f9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-49275a02f9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-6de15e8f0f has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-49275a02f9 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. |