Bug 1994234 - Review Request: rust-escape_string - Very efficiently parse backslash-escaped strings
Summary: Review Request: rust-escape_string - Very efficiently parse backslash-escaped...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-08-17 05:34 UTC by Davide Cavalca
Modified: 2022-07-15 01:36 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-07-06 20:15:03 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github njaard sonnerie pull 14 0 None open Include license text in all published crates 2022-02-13 06:12:13 UTC

Description Davide Cavalca 2021-08-17 05:34:25 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-escape_string/rust-escape_string.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-escape_string/rust-escape_string-0.1.1-1.fc36.src.rpm

Description:
Very efficiently parse backslash-escaped strings.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2021-08-17 05:34:27 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=73990604

Comment 2 Fabio Valentini 2022-01-21 21:55:46 UTC
The BSD-2-Clause license requires redistributed sources to contain a copy of the license text.
This is not the case here, the crate is published without a LICENSE file.

Please report this issue upstream (while this crate is old, upstream is still active).
Adding a symlink to the LICENSE file that sits at the root of the project's GitHub repo should be enough to make "cargo publish" include the LICENSE file next time they publish a version for escape_string.

In the meantime, you could include that LICENSE file as a second source file, since it is obvious that it is the file that should apply to this (sub-)project too.

Comment 3 Fabio Valentini 2022-01-21 21:56:19 UTC
Oh, and please re-generate the .spec file with rust2rpm 20.

Comment 4 Davide Cavalca 2022-02-13 06:12:13 UTC
Put up https://github.com/njaard/sonnerie/pull/14 to get the license sorted out upstream.

Comment 5 Fabio Valentini 2022-05-01 13:51:13 UTC
I don't know what happened, the pull request was closed as "Merged", but the change does not show up in the master branch.
Maybe the developer accidentally force-pushed changes that overwrote your changes from the PR?

Comment 6 Zbigniew Jędrzejewski-Szmek 2022-07-03 20:48:47 UTC
Maybe it'd be easier to just include the license file as SOURCE1 until this is resolved upstream?
Also should be re-generated with rust2rpm-21 now.

Comment 7 Davide Cavalca 2022-07-05 03:41:39 UTC
Not sure what happened either, but I've commented on the original PR and added LICENSE as an extra Source for now.

Spec URL: https://dcavalca.fedorapeople.org/review/rust-escape_string/rust-escape_string.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-escape_string/rust-escape_string-0.1.2-1.fc37.src.rpm

Changelog:
- rerun rust2rpm
- update to 0.1.2
- add missing LICENSE

Comment 8 Zbigniew Jędrzejewski-Szmek 2022-07-05 09:14:15 UTC
+ package name is OK
+ license is acceptable for Fedora (BSD)
+ license is specified correctly
+ latest version
+ builds and installs OK
+ latest rust2rpm was used

Hmm,the license file is now listed twice. Please change
- %license LICENSE
+ %license %{crate_instdir}/LICENSE
(That'll generate a warning about the file being listed twice, but that's a known issue.)

With that change, rpmlint only says: no-documentation, strange-permission,
which are both irrelevant.

Package is APPROVED.

Comment 9 Davide Cavalca 2022-07-06 03:12:59 UTC
Thanks! I'll fix the LICENSE thing on import.

$ fedpkg request-repo rust-escape_string 1994234
https://pagure.io/releng/fedora-scm-requests/issue/45513

Comment 10 Gwyn Ciesla 2022-07-06 19:34:14 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-escape_string

Comment 11 Fedora Update System 2022-07-06 20:12:07 UTC
FEDORA-2022-8faf7bbb7e has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8faf7bbb7e

Comment 12 Fedora Update System 2022-07-06 20:15:03 UTC
FEDORA-2022-8faf7bbb7e has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2022-07-06 20:24:06 UTC
FEDORA-2022-6de15e8f0f has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-6de15e8f0f

Comment 14 Fedora Update System 2022-07-06 20:31:55 UTC
FEDORA-2022-49275a02f9 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-49275a02f9

Comment 15 Fedora Update System 2022-07-07 01:36:27 UTC
FEDORA-2022-6de15e8f0f has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-6de15e8f0f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-6de15e8f0f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2022-07-07 02:06:35 UTC
FEDORA-2022-49275a02f9 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-49275a02f9 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-49275a02f9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2022-07-15 01:16:38 UTC
FEDORA-2022-6de15e8f0f has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2022-07-15 01:36:09 UTC
FEDORA-2022-49275a02f9 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.