Bug 1994669

Summary:	Replace "Foreman server" statement with "Satellite server" in the error message printed by satellite-installer on capsule 6.10
Product:	Red Hat Satellite	Reporter:	Sayan Das <saydas>
Component:	Installer	Assignee:	wclark
Status:	CLOSED ERRATA	QA Contact:	Omkar Khatavkar <okhatavk>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.10.0	CC:	ahumbe, egolov, gtalreja, inecas, sshtein, wclark, zhunting
Target Milestone:	6.10.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	All
OS:	Unspecified
Whiteboard:
Fixed In Version:	foreman-installer-2.5.2.5-1,foreman-installer-2.5.2.6-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-11-16 14:13:10 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sayan Das 2021-08-17 16:29:35 UTC

Description of problem:

This is more of an RFE i would assume but I am filing it as a Bug for now.

On Capsule 6.10, if satellite-installer fails with some error related to SSL, It's prints a message saying

"Check /var/log/foreman/production.log on Foreman server for detailed information"

The term Foreman server is for upstream. We should either replace it i.e.

"Check /var/log/foreman/production.log on the Satellite server for detailed information"

or, we should mention the FQDN of satellite:

"Check /var/log/foreman/production.log on the satellite.example.com server for detailed information"

Version-Release number of selected component (if applicable):

Red Hat Capsule 6.10 [ satellite-installer ]

How reproducible:

Mostly when the installer fails due to an SSL issue

Steps to Reproduce:

1. Install satellite and capsule 6.10 with custom certs

2. Run "satellite-installer --certs-reset" on satellite to revert back to Self-Signed cert.

3. Don't create a new certificate tar for the capsule but use the existing one which still has the old certificate rpm and then execute satellite-installer command on the capsule and monitor the output.

Actual results:

2021-08-17 21:34:06 [ERROR ] [configure] /Stage[main]/Foreman_proxy::Register/Foreman_smartproxy[capsule.example.com]: Failed to call refresh: Error making PUT request to https://satellite.example.com/api/v2/smart_proxies/2/refresh: Response: 500 Internal Server Error: Check /var/log/foreman/production.log on Foreman server for detailed information

2021-08-17 21:34:06 [ERROR ] [configure] /Stage[main]/Foreman_proxy::Register/Foreman_smartproxy[capsule.example.com]: Error making PUT request to https://satellite.example.com/api/v2/smart_proxies/2/refresh: Response: 500 Internal Server Error: Check /var/log/foreman/production.log on Foreman server for detailed information
2021-08-17 21:34:07 [NOTICE] [configure] System configuration has finished.

Expected results:

Same as what is mentioned in the Description part i.e. improvement of error message statement.

Additional info:

Comment 3 Evgeni Golov 2021-08-23 08:47:12 UTC

This is in puppet-foreman:lib/puppet/provider/foreman_resource/rest_v3.rb, and I don't think it's easily brand-able :(

Comment 4 wclark 2021-08-23 15:10:57 UTC

Referring to Foreman/Satellite server is difficult to accomplish without introducing upstream/downstream differences that are harder to maintain.

So I went the route of using the FQDN instead. This is even more specific and should inform the user exactly where to look

The PR is at https://github.com/theforeman/puppet-foreman/pull/988

Comment 5 Bryan Kearney 2021-08-24 20:05:37 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/33320 has been resolved.

Comment 11 errata-xmlrpc 2021-11-16 14:13:10 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Satellite 6.10 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:4702