Bug 1998665

Patch over thunderbird-91.0.3-1.fc36.src.rpm:

--- thunderbird.spec	2021-08-26 04:37:14.000000000 -0400
+++ thunderbird.spec.dave	2021-08-27 18:17:45.636665732 -0400
@@ -318,6 +318,8 @@
 echo "ac_add_options --without-system-nss" >> .mozconfig
 %endif
 
+echo "ac_add_options --with-unsigned-addon-scopes=app,system --allow-addon-sideload" >> .mozconfig
+
 # Second arches fail to start with jemalloc enabled
 %ifnarch %{ix86} x86_64
 echo "ac_add_options --disable-jemalloc" >> .mozconfig
@@ -453,6 +455,7 @@
 MOZ_OPT_FLAGS="$MOZ_OPT_FLAGS -Wformat-security -Wformat -Werror=format-security"
 %else
 # Workaround for mozbz#1531309
+export MOZ_REQUIRE_SIGNING=
 MOZ_OPT_FLAGS=$(echo "$MOZ_OPT_FLAGS" | %{__sed} -e 's/-Werror=format-security//')
 %endif
 # Use hardened build?

*** Bug 1998999 has been marked as a duplicate of this bug. ***

*** Bug 1998707 has been marked as a duplicate of this bug. ***

It does not seem fixed as of thunderbird-91.0.3-2.fc34.x86_64.

I just upgraded from thunderbird-91.0.3-1.fc34.x86_64 to thunderbird-91.0.3-2.fc34.x86_64

Problem is NOT fixed in 91.0.3-2

Created attachment 1820281 [details]
Fix for thunderbird 91.03-2

See https://phabricator.services.mozilla.com/D124361

Yes, it's still kind of broken ATM. I'm able to switch the language in fresh profile. I found out that the $profile/extensions.json has the all langpacks userDisabled set to true in old langpack. I'm not sure if that's your case, but it's keeping resetting to the true when extensions.json is deleted.

I built Thunderbird 91.0.3-2 plus the patch from https://phabricator.services.mozilla.com/D124361 and adding an add-on works again (in my case TBsync + EAS). The packages are available here:
https://copr.fedorainfracloud.org/coprs/patrickl/thunderbird/

(In reply to Patrick Laimbock from comment #8)
> I built Thunderbird 91.0.3-2 plus the patch from
> https://phabricator.services.mozilla.com/D124361 and adding an add-on works
> again (in my case TBsync + EAS). The packages are available here:
> https://copr.fedorainfracloud.org/coprs/patrickl/thunderbird/

Great news. I did an upgrade from 78.12.0 to your built and all works well again. I can switch to german language pack and after a restart, all add-ons and localisation works for me.
Thank you a lot.

(In reply to Patrick Laimbock from comment #8)
> I built Thunderbird 91.0.3-2 plus the patch from
> https://phabricator.services.mozilla.com/D124361 and adding an add-on works
> again (in my case TBsync + EAS). The packages are available here:
> https://copr.fedorainfracloud.org/coprs/patrickl/thunderbird/

Hi Patrick, you did the job !
I just upgraded from hunderbird-91.0.3-2.fc34.x86_64 from Fedora repo to hunderbird-91.0.3-3.fc34.x86_64 from your copr repo.
I am now able to install french language and enable extensions.
Thanks for your job.

(In reply to Harald Reindl from comment #11)
> may i ask what's wrong with you maintainers throw TB91 on Fedora 33 users?
> guess why we didn't jump to F34 until now - to get obvious issues fixed
> before

I'm not a maintainer but here is the Fedora policy if you have an issue with this update:
https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/#problems-or-issues-with-updates

Patrick's TB 91.0.3 patch compiled for F33 : 
https://copr.fedorainfracloud.org/coprs/ifas/thunderbird/

FEDORA-2021-7a74c98205 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-7a74c98205

FEDORA-2021-7e4dfca020 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-7e4dfca020

FEDORA-2021-9f357482fe has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-9f357482fe

Please test the latest 91.1.0 version. 

Regarding disabled langpacks: it's possible that you have already disabled langpacks because of starting the firefox with wrong 'extensions.autoDisableScopes' preference. It must be set to 0. Otherwise the system langpacks will be disabled in the profile and there's no reverse for that, only deleting extensions.json from your profile. The extensions.json will be regenerated during the next start from extensions in the user profile, so the installed extensions won't be removed.

Please feel free to give me a feedback and I'm sorry for the troubles.

FEDORA-2021-7e4dfca020 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-7e4dfca020`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-7e4dfca020

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

(In reply to Jan Horak from comment #17)
> Please test the latest 91.1.0 version. 

thunderbird-91.1.0-1.fc33.x86_64 works fine :
- new addons are installed ;
- existing addons are enabled.

(did not test langpacks)

FEDORA-2021-7a74c98205 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-7a74c98205`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-7a74c98205

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2021-9f357482fe has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-9f357482fe`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-9f357482fe

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2021-7e4dfca020 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2021-7a74c98205 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2021-9f357482fe has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.