Bug 1999060

Summary: Can not close help window in the installer
Product: Red Hat Enterprise Linux 9 Reporter: Jan Stodola <jstodola>
Component: gnome-kioskAssignee: Ray Strode [halfline] <rstrode>
Status: CLOSED ERRATA QA Contact: Tomas Pelka <tpelka>
Severity: low Docs Contact:
Priority: unspecified    
Version: 9.0CC: bartosznyczaj, erco, fmuellner, jadahl, jkonecny, rstrode, tpelka, vslavik
Target Milestone: rcKeywords: Triaged
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: gnome-kiosk-40.0-5.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1998460 Environment:
Last Closed: 2023-05-09 07:36:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshot
none
gnome-kiosk patch that fixes this none

Description Jan Stodola 2021-08-30 10:56:41 UTC
+++ This bug was initially created as a clone of Bug #1998460 +++

Description of problem:

During installation, if I open the help window, I can not figure out how to close it to resume the installation process. I've tried a variety of keyboard shortcuts and have not found a working one but I think this really needs an obvious close button for a better user experience.

Version-Release number of selected component (if applicable):

anaconda-35.22-1.fc35 (was still rawhide when I downloaded the image)

How reproducible:

Always

Steps to Reproduce:
1. Boot an ISO to start an installation
2. Open the help by clicking on the help button

Actual results:

Can not close the help dialog to resume the installation

Expected results:

Obvious "Close help" button to close the help to resume installation.
Additional info:

--- Additional comment from Vladimír Slávik on 2021-08-30 12:29:57 CEST ---

Timothée, thank you for the report. Can you please clarify what is missing, or perhaps attach a screenshot? I always see the help window with heading (?) that has the standard [x] button. So I can click that. I can also resize the window to smaller, and just click the anaconda GUI to "switch" the active window. I can also do Ctrl+W to close the window...

--- Additional comment from Vladimír Slávik on 2021-08-30 12:40:15 CEST ---

Oh, I sort of reproduced it now. It seems that dragging the help window away from its maximized position causes it to be chromeless the next time it appears, and then ever after. As long as I just [x] it away and do not mess with it, it comes back with all the bits. There might be more actions that cause the help to lose the chrome, of course, I didn't try much.

Comment 3 Jan Stodola 2022-01-27 09:03:45 UTC
Just a confirmation that this bug is also reproducible on RHEL-9.0 with anaconda-34.25.0.25-1.el9.

Comment 4 Bartosz Nyczaj 2022-06-15 08:39:15 UTC
I was able to reproduce this bug on newest RHEL 9.0 GA (2022-05-05) with anaconda-34.25.0.29-1.el9_0 and on other OS built from code of RHEL.

Comment 5 Vladimír Slávik 2022-06-15 10:29:24 UTC
Hello GNOME, this is probably something on your side of the stack. Quoting https://bugzilla.redhat.com/show_bug.cgi?id=1998460#c7 :

> After fiddling with this more, it appears that most of the assumptions Anaconda GUI made about modality etc. are no longer true. The list so far is:
> - in all GNOME-based environments, yelp starts maximized (but not under KDE)
> - on boot.iso under gnome-kiosk, yelp loses the title bar after unmaximizing (this very bug)
> - on boot.iso under gnome-kiosk, nm-connection-editor is not really modal with --keep-above, it merely stays on top

Can you please help us understand this?

Comment 6 Jan Stodola 2022-10-06 06:43:31 UTC
Hi Ray,
could you please advise how to move forward with this problem? Is there an easy workaround for anaconda?

Comment 7 Jan Stodola 2022-10-06 06:44:55 UTC
*** Bug 2132491 has been marked as a duplicate of this bug. ***

Comment 8 Ray Strode [halfline] 2022-10-06 13:17:59 UTC
sorry i haven't tried to reproduce at all. anaconda is just running yelp ? can you provide a screenshot?

Comment 9 Ray Strode [halfline] 2022-10-06 13:25:57 UTC
(nm on the screenshot, i've reproduced in a vm)

Comment 10 Jan Stodola 2022-10-06 13:26:40 UTC
Created attachment 1916494 [details]
screenshot

root        1700  2.1 13.8 1456812 346016 pts/0  Ssl+ 13:20   0:05  \_ /usr/bin/python3 /sbin/anaconda
root        1748  0.0  0.2  15540  7028 pts/0    S+   13:21   0:00  |   \_ dbus-daemon --print-address --syslog --config-file=/usr/share/anaconda/dbus/anaconda-bus.conf
root        1903  0.8  4.7 573908 119152 tty6    Ssl+ 13:21   0:02  |   \_ /usr/libexec/Xorg -br -logfile /tmp/X.log :1 vt6 -s 1440 -ac -nolisten tcp -dpi 96 -noreset
root        1911  1.9  5.8 1156960 145172 pts/0  Sl+  13:21   0:04  |   \_ gnome-kiosk --display :1 --sm-disable --x11
root        1913  0.0  0.5  21416 13080 pts/0    S+   13:21   0:00  |   \_ /usr/lib/systemd/systemd --user
root        1936  0.0  0.1  10548  4308 ?        Ss   13:21   0:00  |   |   \_ /usr/bin/dbus-broker-launch --scope user
root        1937  0.0  0.1   4992  2716 ?        S    13:21   0:00  |   |   |   \_ dbus-broker --log 4 --controller 9 --machine-id 863ec63d3e594243ac8e2cd4a782b201 --max-bytes 100000000000000 --max-fds 25000000000000 --max-matches 50000
root        1952  0.0  0.3 308584  8136 ?        Ssl  13:21   0:00  |   |   \_ /usr/libexec/at-spi-bus-launcher
root        1957  0.0  0.2  15144  6036 ?        S    13:21   0:00  |   |   |   \_ /usr/bin/dbus-daemon --config-file=/usr/share/defaults/at-spi2/accessibility.conf --nofork --print-address 3
root        2055  0.0  0.2 161868  6840 ?        Sl   13:21   0:00  |   |   \_ /usr/libexec/at-spi2-registryd --use-gnome-session
root        2353  0.6  3.6 103929964 91360 pts/0 Sl+  13:21   0:01  |   \_ yelp ghelp:/usr/share/anaconda/help/rhel/en-US/anaconda-help.xml?graphical-installation_graphical-installation
root        2368  0.0  1.8 87243900 45796 pts/0  SLl+ 13:21   0:00  |       \_ /usr/libexec/webkit2gtk-4.0/WebKitNetworkProcess 13 17
root        2370  0.4  7.9 104421884 198564 pts/0 SLl+ 13:21   0:00  |       \_ /usr/libexec/webkit2gtk-4.0/WebKitWebProcess 17 17

Comment 11 Ray Strode [halfline] 2022-10-06 13:29:35 UTC
I think this commit should fix it:

https://gitlab.gnome.org/GNOME/yelp/-/commit/245c0936cd026f0cce5d9a63870a1fdfdbe4fab3

Comment 12 Ray Strode [halfline] 2022-10-06 13:46:47 UTC
i just quickly tried it and it's not exactly working right even with that commit

Comment 13 Ray Strode [halfline] 2022-10-06 15:16:29 UTC
Created attachment 1916549 [details]
gnome-kiosk patch that fixes this

So what's happening here is, gnome-kiosk isn't detecting anaconda as "the main app" because anaconda isn't making it's window go fullscreen when it goes fullscreen. Instead it's just going monitor sized.

gnome-kiosk then doesn't consider it the "main" kiosk application and promotes yelp to that.

The above patch changes the heuristic to pick up anaconda too, so yelp gets second class status as it should.

This could be fixed in anaconda too, I think, by making the anaconda window fullscreen.

Comment 14 Vladimír Slávik 2022-10-11 13:31:22 UTC
> This could be fixed in anaconda too, I think, by making the anaconda window fullscreen.

Tried that just now with https://github.com/rhinstaller/anaconda/pull/4373. However, going fullscreen does not appear to change the behavior. 

Ray, is there some easy way to get a RPM with the patched yelp - I mean this from comment 12?

> https://gitlab.gnome.org/GNOME/yelp/-/commit/245c0936cd026f0cce5d9a63870a1fdfdbe4fab3

Comment 15 Ray Strode [halfline] 2022-10-11 13:42:57 UTC
i could give you a scratch build with the commit you mention from comment 11, but like I said in comment 12, it's not really working right with that change either. gnome-kiosk is getting confused so it only works after closing and opening the window once (with ctrl-w). Would you like a scratch build of gnome-kiosk with the fix from comment 13 ?

Comment 16 Ray Strode [halfline] 2022-10-11 14:03:27 UTC
gnome-kiosk scratch build started here: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=48216862

assuming it doesn't fail, it should be ready soon I think.

Comment 17 Ray Strode [halfline] 2022-10-11 14:35:23 UTC
builders seem hung up so i did a c9s scratch build instead: https://kojihub.stream.rdu2.redhat.com/koji/taskinfo?taskID=1497774

Comment 18 Vladimír Slávik 2022-10-14 12:59:27 UTC
Ray, thank you, this appears to resolve the issue!

(It's weird, why does this work and full-screening anaconda does not, but never mind...)

Comment 23 errata-xmlrpc 2023-05-09 07:36:57 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (gnome-kiosk bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2233