Bug 199920
| Summary: | Review Request: Palantir | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tim Niemueller <tim> |
| Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hdegoede, panemade, rpm |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-11-26 18:37:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Tim Niemueller
2006-07-24 11:18:34 UTC
SRPM URL is http://www.niemueller.de/projects/extrpms/packages/fedora-extras-5/palantir-2.6-1.src.rpm Not able to download SRPM ERROR 404: Not Found Please try again. It's there now. Doesn't build for me as normal user, because it tries to chown installed files:
if [ ! -d /var/tmp/palantir-root/usr/share/palantir ] ; then \
mkdir -p /var/tmp/palantir-root/usr/share/palantir ; \
chown root /var/tmp/palantir-root/usr/share/palantir ; \
fi
chown: changing ownership of `/var/tmp/palantir-root/usr/share/palantir':
Operation not permitted
I guess this can be circumvented for the dir case by first doing an mkdir -p.
Please post a new version with this fixed.
New package online at http://www.niemueller.de/projects/extrpms/packages/fedora-extras-5/palantir-2.6-2.src.rpm (spec at original URL). All rpmlint warnings have been fixed, scripts have been updated according to hints given (in the other review requests). The mentioned problem has been fixed with an extended Makefile patch. MUST: ===== O rpmlint output is: W: palantir hardcoded-packager-tag Tim W: palantir redundant-prefix-tag W: palantir setup-not-quiet W: palantir mixed-use-of-spaces-and-tabs These all must be fixed * Package and spec file named appropriately * Packaged according to packaging guidelines * License ok, license file included * spec file is legible and in Am. English. * Source matches upstream * "Compiles" and builds on FC-5 i386 * BR: ok * No locales * No shared libraries * Not relocatable * Package owns / or requires all dirs * No duplicate files & Permissions ok * %clean & macro usage OK * Contains code only * %doc does not affect runtime, and isn't large enough to warrent a sub package * no -devel package needed, no libs / .la files. * no .desktop file required MUST fix ======== * rpmlint output: W: palantir hardcoded-packager-tag Tim Remove the packager tag W: palantir redundant-prefix-tag Remove the prefix tag W: palantir setup-not-quiet Add -q to %setup W: palantir mixed-use-of-spaces-and-tabs Only uses spaces for indenting, not tabs * Add: "%defattr(-,root,root,-)" to the subpackages %files . * Source0 must be a full URL Questions: ========== * I assume the java client doesn't build with gcj? Have you tried? * Why is the building of the QT client optional and not done by default, since it is in a subpackage the user can always choose to not install it so I would prefer to always build it and atleast build it by default. Removing FE-NEEDSPONSOR, as submitter was sponsored in: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175047 ping? ping again? If I still get no response within one week I'm closing this as a dead review. |