Bug 2000598
Summary: | Review Request: python-pathos - Parallel graph management and execution in heterogeneous computing | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ankur Sinha (FranciscoD) <sanjay.ankur> |
Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | mhroncok, package-review, zbyszek |
Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2021-09-07 19:07:34 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1276941, 1914344 |
Description
Ankur Sinha (FranciscoD)
2021-09-02 13:16:06 UTC
typos: "distributes service" → distributed service, "users laptop" → user's laptop, "atomistic" → atomic + package name is OK + license is acceptable for Fedora (BSD) + license is specified correctly + latest version + builds and installs without issue + fedora-review finds no problems + rpmlint only has false positive spelling suggestions + BR/R/P look OK + %check is present and passes Package is APPROVED. Thanks very much Zbigniew. Requesting SCM now. I'll correct the typos before import. > export PYTHONPATH="$PYTHONPATH:%{python3_sitearch}:%{python3_sitelib}"
Just curious: Why is this used in %check? Should it include %{buidlroot}%{python3_sitearch/lib} instead?
Nitpicks: - rm -rf %{pypi_name}.egg-info is not needed with pyproject RPM macros. - %{python3} is prefered over %{__python3} (In reply to Miro Hrončok from comment #3) > > export PYTHONPATH="$PYTHONPATH:%{python3_sitearch}:%{python3_sitelib}" > > Just curious: Why is this used in %check? Should it include > %{buidlroot}%{python3_sitearch/lib} instead? Aha, I've missed the %{buildroot} bit there. Correcting that now. `export PYTHONPATH="."` also works since it finds the built copy. So does `export PYTHONPATH=":"`---does a colon at the start ":" mean cwd? Maybe that's why my wrong command worked? Anyway, I'm using the full buildroot/ path now so it finds the installed copy. (In reply to Miro Hrončok from comment #4) > Nitpicks: > > - rm -rf %{pypi_name}.egg-info is not needed with pyproject RPM macros. > - %{python3} is prefered over %{__python3} Thanks, corrected. Updated spec/srpm: Spec URL: https://ankursinha.fedorapeople.org/python-pathos/python-pathos.spec SRPM URL: https://ankursinha.fedorapeople.org/python-pathos/python-pathos-0.2.8-1.fc34.src.rpm (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pathos > does a colon at the start ":" mean cwd?
It seems so.
FEDORA-2021-040d0bf6ef has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-040d0bf6ef FEDORA-2021-040d0bf6ef has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-040d0bf6ef \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-040d0bf6ef See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-040d0bf6ef has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. |