Bug 2001322

Summary:	Taint message generated during vm running is not preserved during libvirtd restart
Product:	Red Hat Enterprise Linux 9	Reporter:	John Ferlan <jferlan>
Component:	libvirt	Assignee:	khanicov
libvirt sub component:	General	QA Contact:	Fangge Jin <fjin>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	unspecified	CC:	fjin, jdenemar, khanicov, lmen, mprivozn, virt-maint, xuzhang
Version:	9.0	Keywords:	Triaged, Upstream
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-7.7.0-1.el9	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1965589	Environment:
Last Closed:	2022-05-17 12:45:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:	7.7.0
Embargoed:
Bug Depends On:	1965589
Bug Blocks:

Description John Ferlan 2021-09-05 14:12:26 UTC

+++ This bug was initially created as a clone of Bug #1965589 +++

Description of problem:
Start a vm, execute some operations that can produce taint message, then restart libvirtd and check dominfo, and found that Taint message generated during vm running is not preserved during libvirtd restart

Version-Release number of selected component (if applicable):
libvirt-7.3.0-1.module+el8.5.0+11004+f4810536.x86_64


How reproducible:
100%

Steps to Reproduce:
1. Start a vm

2. Execute some operations that can produce taint message, e.g.
1) Execute agent command
virsh qemu-agent-command $vm '{"execute": "guest-info"}'

2) Hotplug a cdrom type disk sourced by host block device
# virsh attach-disk avocado-vt-vm1 --source /dev/cdrom --type cdrom --sourcetype block --target hda

3) Hotplug a interface device with script
# virsh attach-device avocado-vt-vm1 net.xml
# cat net.xml 
<interface type='ethernet'>
<script path='/etc/qemu-ifup'/> 
</interface>


3. Check dominfo:
# virsh dominfo avocado-vt-vm1
Id:             4
Name:           avocado-vt-vm1
UUID:           fa26e276-1bb1-47eb-be0e-57e8bb8cf0d9
OS Type:        hvm
State:          running
...
Messages:       tainted: network configuration using opaque shell scripts
                tainted: potentially unsafe use of host CPU passthrough
                tainted: use of host cdrom passthrough
                tainted: custom guest agent control commands issued

4. Restart libvirtd

5. Check dominfo:
# virsh dominfo avocado-vt-vm1
Id:             4
Name:           avocado-vt-vm1
UUID:           fa26e276-1bb1-47eb-be0e-57e8bb8cf0d9
OS Type:        hvm
State:          running
...
Messages:       tainted: potentially unsafe use of host CPU passthrough


Actual results:
Taint message that are generated when vm starts is preserved during libvirtd restart, but not for those generated when vm is running

Expected results:
All taint messages should be preserved during libvirtd restart

Additional info:

--- Additional comment from  on 2021-07-22 15:27:05 UTC ---

Patch proposed on the list:
https://listman.redhat.com/archives/libvir-list/2021-July/msg00584.html

--- Additional comment from Fangge Jin on 2021-07-29 06:09:06 UTC ---

Forgot to mention that hotplug cdrom/interface actually failed in comment 0

--- Additional comment from  on 2021-08-12 11:50:14 UTC ---

Merged upstream as:

878cbd0f6a qemu: save status xml after generating taint message

v7.6.0-101-g878cbd0f6a

Comment 1 Fangge Jin 2021-10-14 03:34:02 UTC

Test with libvirt-client-7.8.0-1.el9.x86_64, passed

Comment 5 Fangge Jin 2021-11-02 02:22:21 UTC

Verified with libvirt-7.8.0-1.el9.x86_64

Comment 7 errata-xmlrpc 2022-05-17 12:45:08 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: libvirt), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2390