RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1965589 - Taint message generated during vm running is not preserved during libvirtd restart
Summary: Taint message generated during vm running is not preserved during libvirtd re...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: libvirt
Version: 8.5
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: rc
: 8.6
Assignee: khanicov
QA Contact: Fangge Jin
URL:
Whiteboard:
Depends On:
Blocks: 2001322
TreeView+ depends on / blocked
 
Reported: 2021-05-28 08:44 UTC by Fangge Jin
Modified: 2022-05-10 13:24 UTC (History)
7 users (show)

Fixed In Version: libvirt-7.8.0-1.module+el8.6.0+12978+7d7a0321
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 2001322 (view as bug list)
Environment:
Last Closed: 2022-05-10 13:18:42 UTC
Type: Bug
Target Upstream Version: 7.7.0
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2022:1759 0 None None None 2022-05-10 13:19:52 UTC

Description Fangge Jin 2021-05-28 08:44:33 UTC
Description of problem:
Start a vm, execute some operations that can produce taint message, then restart libvirtd and check dominfo, and found that Taint message generated during vm running is not preserved during libvirtd restart

Version-Release number of selected component (if applicable):
libvirt-7.3.0-1.module+el8.5.0+11004+f4810536.x86_64


How reproducible:
100%

Steps to Reproduce:
1. Start a vm

2. Execute some operations that can produce taint message, e.g.
1) Execute agent command
virsh qemu-agent-command $vm '{"execute": "guest-info"}'

2) Hotplug a cdrom type disk sourced by host block device
# virsh attach-disk avocado-vt-vm1 --source /dev/cdrom --type cdrom --sourcetype block --target hda

3) Hotplug a interface device with script
# virsh attach-device avocado-vt-vm1 net.xml
# cat net.xml 
<interface type='ethernet'>
<script path='/etc/qemu-ifup'/> 
</interface>


3. Check dominfo:
# virsh dominfo avocado-vt-vm1
Id:             4
Name:           avocado-vt-vm1
UUID:           fa26e276-1bb1-47eb-be0e-57e8bb8cf0d9
OS Type:        hvm
State:          running
...
Messages:       tainted: network configuration using opaque shell scripts
                tainted: potentially unsafe use of host CPU passthrough
                tainted: use of host cdrom passthrough
                tainted: custom guest agent control commands issued

4. Restart libvirtd

5. Check dominfo:
# virsh dominfo avocado-vt-vm1
Id:             4
Name:           avocado-vt-vm1
UUID:           fa26e276-1bb1-47eb-be0e-57e8bb8cf0d9
OS Type:        hvm
State:          running
...
Messages:       tainted: potentially unsafe use of host CPU passthrough


Actual results:
Taint message that are generated when vm starts is preserved during libvirtd restart, but not for those generated when vm is running

Expected results:
All taint messages should be preserved during libvirtd restart

Additional info:

Comment 1 khanicov 2021-07-22 15:27:05 UTC
Patch proposed on the list:
https://listman.redhat.com/archives/libvir-list/2021-July/msg00584.html

Comment 2 Fangge Jin 2021-07-29 06:09:06 UTC
Forgot to mention that hotplug cdrom/interface actually failed in comment 0

Comment 3 khanicov 2021-08-12 11:50:14 UTC
Merged upstream as:

878cbd0f6a qemu: save status xml after generating taint message

v7.6.0-101-g878cbd0f6a

Comment 4 John Ferlan 2021-09-05 14:18:07 UTC
Move to RHEL since RHEL-AV will only be a rebuild of RHEL starting w/ 8.6.0

Comment 7 Fangge Jin 2021-10-26 10:02:41 UTC
Verify with libvirt-7.8.0-1.module+el8.6.0+12982+5e169f40.x86_64

One issue: 
There is no taint message generated when live attach a cdrom sourced by a host block device:
# virsh attach-disk avocado-vt-vm1 --source /dev/cdrom --type cdrom --sourcetype block --target hda

But this issue seems not related with this fix for this bug. Other scenarios work well.

Comment 9 errata-xmlrpc 2022-05-10 13:18:42 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: virt:rhel and virt-devel:rhel security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:1759


Note You need to log in before you can comment on or make changes to this bug.