Bug 2001389

Summary: [RFE] network: allow configuring dhcp lease time
Product: Red Hat Enterprise Linux 9 Reporter: John Ferlan <jferlan>
Component: libvirtAssignee: Michal Privoznik <mprivozn>
libvirt sub component: General QA Contact: yalzhang <yalzhang>
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: unspecified CC: dzheng, jdenemar, jloscar, jsuchane, laine, mprivozn, virt-maint, xuzhang, yalzhang
Version: 9.0Keywords: FutureFeature, Triaged, Upstream
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-7.7.0-1.el9 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: 1926508 Environment:
Last Closed: 2022-05-17 12:45:08 UTC Type: Feature Request
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version: 7.4.0
Embargoed:
Bug Depends On: 1926508    
Bug Blocks:    

Description John Ferlan 2021-09-05 23:44:07 UTC
+++ This bug was initially created as a clone of Bug #1926508 +++

1. Proposed title of this feature request
Pull Libvirt 6.3.0 to customize lease time libvirt RHEL 8

2. Who is the customer behind the request?

Account: IBM acct # 698951
TAM customer: yes
CSM customer: no
Strategic: no

3. What is the nature and description of the request?
Please include libvirt 6.3.0 - Lease time option included for network DHCP settings

4. Why does the customer need this?
We can enable users to configure expiry time for leases for networks where libvirt manages DHCP. The time can be specified for whole range and/or fine tuned per individual host.
Relates to Windows 10 guests. Currently we are respinning/patching dnsmasq.

5. How would the customer like to achieve this? 
Patching the functionality into upcoming release.


6. For each functional requirement listed, specify how Red Hat and the customer can test to confirm the requirement is successfully implemented.
Users can configure expiry time for leases for networks where libvirt manages DHCP. The time can be specified for whole range and/or fine tuned per individual host.

7. Is there already an existing RFE upstream or in Red Hat Bugzilla?
No

8. Does the customer have any specific timeline dependencies and which release would they like to target (i.e. RHEL5, RHEL6)?
RHEL 8

9. Is the sales team involved in this request and do they have any additional input?
No


10. List any affected packages or components.

11. Would the customer be able to assist in testing this functionality if implemented?
Yes

--- Additional comment from yalzhang on 2021-02-09 03:45:33 UTC ---

Summarize all the bugs related with this feature:
1. Upstream bug to introduce this feature: bug 913446
2. Related bug caused by: bug 1908053 which fixed on libvirt-7.0.0-1.el8
3. Another with low priority about error message in negative test scenario: bug 1918674

--- Additional comment from Laine Stump on 2021-02-10 19:31:53 UTC ---

In addition to the 3 patches given in Bug 913446 Comment 19, and the 10 patches in Bug 1908053 Comment 11, and the one patch in Bug 1918674 Comment 1, there is also this bugfix:

commit 4aa1ab0e799aecd88392ea40d70b9f929d44bc4b
Author: Julio Faracco <jcfaracco>
Date:   Sat Apr 25 13:35:37 2020 -0300

    network: Remove memory leak caused by wrong initialization
    

which doesn't seem to have a Bugzilla reported associated with it.

--- Additional comment from Michal Privoznik on 2021-02-15 13:08:34 UTC ---

(In reply to jloscar from comment #0)
> 4. Why does the customer need this?
> We can enable users to configure expiry time for leases for networks where
> libvirt manages DHCP. The time can be specified for whole range and/or fine
> tuned per individual host.
> Relates to Windows 10 guests. Currently we are respinning/patching dnsmasq.

Can you please elaborate on this? Why does IBM need this feature in RHEL? AFAIK, they have access to RHEL-AV where the feature already exists among with its fixes. What problem is IBM trying to solve?

--- Additional comment from RHEL Program Management on 2021-02-17 07:29:27 UTC ---

The keyword FutureFeature has been added. If this bug is not a FutureFeature, please remove from the Summary field any strings containing "RFE, rfe, FutureFeature, FEAT, Feat, feat".

--- Additional comment from Michal Privoznik on 2021-08-26 12:36:00 UTC ---

Since the needinfo wasn't answered in ~6 months I assume it's not that critical and thus I'm moving this to RHEL-8.6.0 where the feature will be picked up by rebase. Moving to POST then.

Comment 1 yalzhang@redhat.com 2021-09-18 06:27:48 UTC
automation ran pass, set it as verified: tested.

Comment 5 yalzhang@redhat.com 2021-10-21 10:35:54 UTC
Test pass with libvirt-7.8.0-1.el9.x86_64 on jenkins. Set the bug to be verified.

Comment 7 errata-xmlrpc 2022-05-17 12:45:08 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: libvirt), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2390