Bug 2001698

Summary:	Review Request: perl-HTTP-Headers-ActionPack - A Perl module to handle the inflation and deflation of complex HTTP header types
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-HTTP-Headers-ActionPack-0.09-2.fc36	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-09-21 17:18:59 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2001699

Description Emmanuel Seyman 2021-09-06 20:46:39 UTC

Spec URL: https://people.parinux.org/~seyman/fedora/perl-HTTP-Headers-ActionPack/perl-HTTP-Headers-ActionPack-0.09-1.fc34.src.rpm
SRPM URL: https://people.parinux.org/~seyman/fedora/perl-HTTP-Headers-ActionPack/perl-HTTP-Headers-ActionPack-0.09-1.fc34.src.rpm
Description:
This is a module to handle the inflation and deflation of complex HTTP
header types. In many cases header values are simple strings, but in
some cases they are complex values with a lot of information encoded in
them. The goal of this module is to make the parsing and analysis of
these headers as easy as calling inflate on a compatible object.

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked: 0 errors, 0 warnings.

Comment 1 Jitka Plesnikova 2021-09-14 08:15:10 UTC

Wrong spec URL

Comment 2 Jitka Plesnikova 2021-09-14 08:35:42 UTC

Spec URL: https://people.parinux.org/~seyman/fedora/perl-HTTP-Headers-ActionPack/perl-HTTP-Headers-ActionPack.spec
SRPM URL: https://people.parinux.org/~seyman/fedora/perl-HTTP-Headers-ActionPack/perl-HTTP-Headers-ActionPack-0.09-1.fc34.src.rpm

Comment 3 Jitka Plesnikova 2021-09-14 08:44:58 UTC

This should be removed or at least bootstrap for initial build and mass rebuild, because it causes cycle 'perl(Web::Machine) <-> perl(HTTP::Headers::ActionPack)'

# optional, not packaged in Fedora
BuildRequires:  perl(Web::Machine)

Comment 4 Jitka Plesnikova 2021-09-17 11:54:19 UTC

(In reply to Jitka Plesnikova from comment #3)
> This should be removed or at least bootstrap for initial build and mass
> rebuild, because it causes cycle 'perl(Web::Machine) <->
> perl(HTTP::Headers::ActionPack)'
> 
> # optional, not packaged in Fedora
> BuildRequires:  perl(Web::Machine)

Emmanuel, could you please solve the cycle?

Comment 5 Emmanuel Seyman 2021-09-17 12:14:43 UTC

(In reply to Jitka Plesnikova from comment #4):
> 
> Emmanuel, could you please solve the cycle?

Sorry, I had fixed this locally but not uploaded the new spec and package.

Spec URL: https://people.parinux.org/~seyman/fedora/perl-HTTP-Headers-ActionPack/perl-HTTP-Headers-ActionPack.spec
SRPM URL: https://people.parinux.org/~seyman/fedora/perl-HTTP-Headers-ActionPack/perl-HTTP-Headers-ActionPack-0.09-2.fc34.src.rpm

Comment 6 Jitka Plesnikova 2021-09-20 08:15:25 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-HTTP-Headers-ActionPack-0.09-2.fc36.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(Encode)
      1 perl(HTTP::Date)
      1 perl(HTTP::Headers::ActionPack::Authorization::Basic)
      1 perl(HTTP::Headers::ActionPack::Authorization::Digest)
      1 perl(HTTP::Headers::ActionPack::Core::Base)
      1 perl(HTTP::Headers::ActionPack::Core::BaseAuthHeader)
      1 perl(HTTP::Headers::ActionPack::Core::BaseHeaderList)
      1 perl(HTTP::Headers::ActionPack::Core::BaseHeaderType)
      1 perl(HTTP::Headers::ActionPack::Core::BaseHeaderWithParams)
      1 perl(HTTP::Headers::ActionPack::LinkHeader)
      1 perl(HTTP::Headers::ActionPack::MediaType)
      1 perl(HTTP::Headers::ActionPack::PriorityList)
      1 perl(HTTP::Headers::ActionPack::Util)
      1 perl(HTTP::Headers::Util)
      1 perl(List::Util)
      1 perl(MIME::Base64)
      1 perl(:MODULE_COMPAT_5.34.0)
      1 perl(Module::Runtime)
      1 perl(overload)
      1 perl(parent)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Sub::Exporter)
      1 perl(Time::Piece)
      1 perl(URI::Escape)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-HTTP-Headers-ActionPack-0.09-2.fc36.noarch.rpm | sort | uniq -c
      1 perl(HTTP::Headers::ActionPack) = 0.09
      1 perl-HTTP-Headers-ActionPack = 0.09-2.fc36
      1 perl(HTTP::Headers::ActionPack::AcceptCharset) = 0.09
      1 perl(HTTP::Headers::ActionPack::AcceptLanguage) = 0.09
      1 perl(HTTP::Headers::ActionPack::AuthenticationInfo) = 0.09
      1 perl(HTTP::Headers::ActionPack::Authorization) = 0.09
      1 perl(HTTP::Headers::ActionPack::Authorization::Basic) = 0.09
      1 perl(HTTP::Headers::ActionPack::Authorization::Digest) = 0.09
      1 perl(HTTP::Headers::ActionPack::ContentNegotiation) = 0.09
      1 perl(HTTP::Headers::ActionPack::Core::Base) = 0.09
      1 perl(HTTP::Headers::ActionPack::Core::BaseAuthHeader) = 0.09
      1 perl(HTTP::Headers::ActionPack::Core::BaseHeaderList) = 0.09
      1 perl(HTTP::Headers::ActionPack::Core::BaseHeaderType) = 0.09
      1 perl(HTTP::Headers::ActionPack::Core::BaseHeaderWithParams) = 0.09
      1 perl(HTTP::Headers::ActionPack::DateHeader) = 0.09
      1 perl(HTTP::Headers::ActionPack::LinkHeader) = 0.09
      1 perl(HTTP::Headers::ActionPack::LinkList) = 0.09
      1 perl(HTTP::Headers::ActionPack::MediaType) = 0.09
      1 perl(HTTP::Headers::ActionPack::MediaTypeList) = 0.09
      1 perl(HTTP::Headers::ActionPack::PriorityList) = 0.09
      1 perl(HTTP::Headers::ActionPack::Util) = 0.09
      1 perl(HTTP::Headers::ActionPack::WWWAuthenticate) = 0.09
Binary provides are Ok.

$ rpmlint ./perl-HTTP-Headers-ActionPack*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved

Comment 7 Emmanuel Seyman 2021-09-20 15:47:12 UTC

(In reply to Jitka Plesnikova from comment #6):
> 
> Resolution:
> Approved

Thank you, Jikta!
Repository requested (https://pagure.io/releng/fedora-scm-requests/issue/37004).

Comment 8 Gwyn Ciesla 2021-09-20 16:08:33 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-HTTP-Headers-ActionPack

Comment 9 Emmanuel Seyman 2021-09-21 17:18:59 UTC

Built for rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1834991