Bug 2001699 - Review Request: perl-Web-Machine - Perl port of Webmachine
Summary: Review Request: perl-Web-Machine - Perl port of Webmachine
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2001698
Blocks: 1858048
TreeView+ depends on / blocked
 
Reported: 2021-09-06 20:51 UTC by Emmanuel Seyman
Modified: 2021-09-21 17:19 UTC (History)
2 users (show)

Fixed In Version: perl-Web-Machine-0.17-2.fc36
Clone Of:
Environment:
Last Closed: 2021-09-21 17:19:46 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Emmanuel Seyman 2021-09-06 20:51:07 UTC
Spec URL: https://people.parinux.org/~seyman/fedora/perl-Web-Machine/perl-Web-Machine-0.17-1.fc34.src.rpm
SRPM URL: https://people.parinux.org/~seyman/fedora/perl-Web-Machine/perl-Web-Machine-0.17-1.fc34.src.rpm
Description:
Web::Machine provides a RESTful web framework modeled as a state machine.
You define one or more resource classes. Each resource represents a single
RESTful URI end point, such as a user, an email, etc. The resource class
can also be the target for POST requests to create a new user, email, etc.

Fedora Account System Username: eseyman

Comment 1 Jitka Plesnikova 2021-09-14 08:15:18 UTC
Wrong spec URL

Comment 3 Jitka Plesnikova 2021-09-20 09:43:11 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok
TODO: Move 'perl(Test::TCP)' from runtime BR to test BR

$ rpm -qp --requires perl-Web-Machine-0.17-1.fc36.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(B)
      1 perl(Carp)
      1 perl(Encode)
      1 perl(Hash::MultiValue)
      1 perl(HTTP::Headers::ActionPack) >= 0.07
      1 perl(HTTP::Status)
      1 perl(IO::Handle::Util)
      1 perl(List::Util)
      1 perl(Locale::Maketext)
      1 perl(:MODULE_COMPAT_5.34.0)
      1 perl(Module::Runtime)
      1 perl(parent)
      1 perl(Plack::Component)
      1 perl(Plack::Request)
      1 perl(Plack::Response)
      1 perl(Plack::Util)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Sub::Exporter)
      1 perl(Try::Tiny)
      1 perl(warnings)
      1 perl(Web::Machine::FSM)
      1 perl(Web::Machine::FSM::States)
      1 perl(Web::Machine::I18N)
      1 perl(Web::Machine::Util)
      1 perl(Web::Machine::Util::BodyEncoding)
      1 perl(Web::Machine::Util::ContentNegotiation)
Binary requires are Ok.

$ rpm -qp --provides perl-Web-Machine-0.17-1.fc36.noarch.rpm | sort | uniq -c
      1 perl(Web::Machine) = 0.17
      1 perl-Web-Machine = 0.17-1.fc36
      1 perl(Web::Machine::FSM) = 0.17
      1 perl(Web::Machine::FSM::States) = 0.17
      1 perl(Web::Machine::I18N) = 0.17
      1 perl(Web::Machine::I18N::en) = 0.17
      1 perl(Web::Machine::Resource) = 0.17
      1 perl(Web::Machine::Util) = 0.17
      1 perl(Web::Machine::Util::BodyEncoding) = 0.17
      1 perl(Web::Machine::Util::ContentNegotiation) = 0.17
Binary provides are Ok.

$ rpmlint ./perl-Web-Machine*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Build failed with an error:
 Checking for unpackaged file(s): /usr/lib/rpm/check-files /builddir/build/BUILDROOT/perl-Web-Machine-0.17-1.fc36.x86_64
 error: Installed (but unpackaged) file(s) found:
   /usr/lib64/perl5/perllocal.pod
   /usr/lib64/perl5/vendor_perl/auto/Web/Machine/.packlist
    Installed (but unpackaged) file(s) found:
   /usr/lib64/perl5/perllocal.pod
   /usr/lib64/perl5/vendor_perl/auto/Web/Machine/.packlist
FIX: Please add to command 'perl Makefile.PL' options 'NO_PACKLIST=1 NO_PERLLOCAL=1'


Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' item, consider fixing 'TODO' item.

Resolution:
Approved

Comment 4 Emmanuel Seyman 2021-09-20 16:33:55 UTC
(In reply to Jitka Plesnikova from comment #3):
>
> TODO: Move 'perl(Test::TCP)' from runtime BR to test BR

Done.

> FIX: Please add to command 'perl Makefile.PL' options 'NO_PACKLIST=1
> NO_PERLLOCAL=1'

Hummm... Not sure how I missed that one, TBH. Fixed.

> Otherwise the package is in line with Fedora and Perl packaging guide lines.
> Please correct all 'FIX' item, consider fixing 'TODO' item.

Spec URL: https://people.parinux.org/~seyman/fedora/perl-Web-Machine/perl-Web-Machine.spec
SRPM URL: https://people.parinux.org/~seyman/fedora/perl-Web-Machine/perl-Web-Machine-0.17-2.fc34.src.rpm

> Resolution:
> Approved

Thank you for the review, Jikta.
Repository requested (https://pagure.io/releng/fedora-scm-requests/issue/37008).

Comment 5 Gwyn Ciesla 2021-09-20 16:46:38 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Web-Machine

Comment 6 Emmanuel Seyman 2021-09-21 17:19:46 UTC
Built for rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1835406


Note You need to log in before you can comment on or make changes to this bug.