Bug 2001700

Summary:	Review Request: perl-Path-Dispatcher - Flexible and extensible dispatch
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Path-Dispatcher-1.08-1.fc36	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-09-21 17:21:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2004268
Bug Blocks:	1858048

Description Emmanuel Seyman 2021-09-06 21:08:30 UTC

Spec URL: https://people.parinux.org/~seyman/fedora/perl-Path-Dispatcher/perl-Path-Dispatcher.spec
SRPM URL: https://people.parinux.org/~seyman/fedora/perl-Path-Dispatcher/perl-Path-Dispatcher-1.08-1.fc34.src.rpm
Description:
Path::Dispatcher's basic operation is that of dispatch. Dispatch takes
a path and a list of rules, and it returns a list of matches. From there,
you can "run" the rules that matched. These phases are distinct so that,
if you need to, you can inspect which rules were matched without ever
running their code-blocks.

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked: 0 errors, 0 warnings

Comment 1 Jitka Plesnikova 2021-09-14 08:26:00 UTC

It's not possible to build due to missing dependency:

No matching package to install: 'perl(MooX::TypeTiny)'

Comment 2 Jitka Plesnikova 2021-09-16 11:10:32 UTC

It is not possible to build the package due to missing BR perl(Module::Build::Tiny) and perl(Module::Build)

Errors from configure prereqs:
{
  'ExtUtils::MakeMaker' => '',
  'Module::Build::Tiny' => 'Can\'t locate Module/Build/Tiny.pm in @INC (you may need to install the Module::Build::Tiny module) (@INC contains: /usr/local/lib64/perl5/5.34 /usr/local/share/perl5/5.34 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at (eval 1) line 1.
'
}
Can't locate Module/Build.pm in @INC (you may need to install the Module::Build module) (@INC contains: /usr/local/lib64/perl5/5.34 /usr/local/share/perl5/5.34 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at Build.PL line 76.



Please add them and provide new spec file.

Comment 3 Jitka Plesnikova 2021-09-16 11:12:18 UTC

Adding 'perl(Module::Build::Tiny) >= 0.034' is enough.

Comment 4 Emmanuel Seyman 2021-09-16 21:24:08 UTC

Too late for the 'NotReady' tag, isn't it?

Spec URL: https://people.parinux.org/~seyman/fedora/perl-Path-Dispatcher/perl-Path-Dispatcher.spec
SRPM URL: https://people.parinux.org/~seyman/fedora/perl-Path-Dispatcher/perl-Path-Dispatcher-1.08-1.fc34.src.rpm

Comment 5 Jitka Plesnikova 2021-09-17 11:49:33 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are ok

$ rpm -qp --requires perl-Path-Dispatcher-1.08-1.fc36.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(constant)
      1 perl(:MODULE_COMPAT_5.34.0)
      1 perl(Moo)
      1 perl(Moo::Role)
      1 perl(MooX::TypeTiny)
      1 perl(overload)
      1 perl(Path::Dispatcher::Dispatch)
      1 perl(Path::Dispatcher::Match)
      1 perl(Path::Dispatcher::Path)
      1 perl(Path::Dispatcher::Rule)
      1 perl(Path::Dispatcher::Rule::Alternation)
      1 perl(Path::Dispatcher::Rule::Always)
      1 perl(Path::Dispatcher::Rule::Chain)
      1 perl(Path::Dispatcher::Rule::CodeRef)
      1 perl(Path::Dispatcher::Rule::Dispatch)
      1 perl(Path::Dispatcher::Rule::Empty)
      1 perl(Path::Dispatcher::Rule::Enum)
      1 perl(Path::Dispatcher::Rule::Eq)
      1 perl(Path::Dispatcher::Rule::Intersection)
      1 perl(Path::Dispatcher::Rule::Metadata)
      1 perl(Path::Dispatcher::Rule::Regex)
      1 perl(Path::Dispatcher::Rule::Sequence)
      1 perl(Path::Dispatcher::Rule::Tokens)
      1 perl(Path::Dispatcher::Rule::Under)
      1 perl(Scalar::Util)
      1 perl(Try::Tiny)
      1 perl(Types::Standard)
      1 perl(Type::Tiny)
      1 perl(Type::Utils)
      1 perl(:VERSION) >= 5.8.1
Binary requires are Ok.

$ rpm -qp --provides perl-Path-Dispatcher-1.08-1.fc36.noarch.rpm | sort | uniq -c
      1 perl(Path::Dispatcher) = 1.08
      1 perl-Path-Dispatcher = 1.08-1.fc36
      1 perl(Path::Dispatcher::Dispatch) = 1.08
      1 perl(Path::Dispatcher::Match) = 1.08
      1 perl(Path::Dispatcher::Path) = 1.08
      1 perl(Path::Dispatcher::Role::Rules) = 1.08
      1 perl(Path::Dispatcher::Rule) = 1.08
      1 perl(Path::Dispatcher::Rule::Alternation) = 1.08
      1 perl(Path::Dispatcher::Rule::Always) = 1.08
      1 perl(Path::Dispatcher::Rule::Chain) = 1.08
      1 perl(Path::Dispatcher::Rule::CodeRef) = 1.08
      1 perl(Path::Dispatcher::Rule::Dispatch) = 1.08
      1 perl(Path::Dispatcher::Rule::Empty) = 1.08
      1 perl(Path::Dispatcher::Rule::Enum) = 1.08
      1 perl(Path::Dispatcher::Rule::Eq) = 1.08
      1 perl(Path::Dispatcher::Rule::Intersection) = 1.08
      1 perl(Path::Dispatcher::Rule::Metadata) = 1.08
      1 perl(Path::Dispatcher::Rule::Regex) = 1.08
      1 perl(Path::Dispatcher::Rule::Sequence) = 1.08
      1 perl(Path::Dispatcher::Rule::Tokens) = 1.08
      1 perl(Path::Dispatcher::Rule::Under) = 1.08
Binary provides are Ok.

$ rpmlint ./perl-Path-Dispatcher*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved

Comment 6 Emmanuel Seyman 2021-09-17 12:22:14 UTC

Thank you for the review, Jikta!
I've requested the repository (https://pagure.io/releng/fedora-scm-requests/issue/36841)

Comment 7 Gwyn Ciesla 2021-09-17 13:07:06 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Path-Dispatcher

Comment 8 Emmanuel Seyman 2021-09-21 17:21:54 UTC

Built for rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1833841