Spec URL: https://people.parinux.org/~seyman/fedora/perl-MooX-TypeTiny/perl-MooX-TypeTiny.spec SRPM URL: https://people.parinux.org/~seyman/fedora/perl-MooX-TypeTiny/perl-MooX-TypeTiny-0.002003-1.fc34.src.rpm Description: This module optimizes Moo type checks when used with Type::Tiny to perform better. It will automatically apply to isa checks and coercions that use Type::Tiny. Non-Type::Tiny isa checks will work as normal. Fedora Account System Username: eseyman Rpmlint Output: perl-MooX-TypeTiny.src: W: spelling-error %description -l en_US isa -> is, visa, Lisa perl-MooX-TypeTiny.src: W: spelling-error %description -l en_US coercions -> coercion, coercion's, coercion s 1 packages and 1 specfiles checked; 0 errors, 2 warnings.
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok FIX: Please add BR - perl(Moo::_Utils) - lib/MooX/TypeTiny.pm:7 $ rpm -qp --requires perl-MooX-TypeTiny-0.002003-1.fc36.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(:MODULE_COMPAT_5.34.0) 1 perl(Moo::Role) 1 perl(Moo::_Utils) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Sub::Quote) 1 perl(warnings) FIX: Please add run-requires - perl(Moo) >= 2.004000 - perl(Type::Tiny) >= 1.008000 $ rpm -qp --provides perl-MooX-TypeTiny-0.002003-1.fc36.noarch.rpm | sort | uniq -c 1 perl(MooX::TypeTiny) = 0.002003 1 perl-MooX-TypeTiny = 0.002003-1.fc36 1 perl(MooX::TypeTiny::Role::GenerateAccessor) Binary provides are Ok. $ rpmlint ./perl-MooX-TypeTiny* perl-MooX-TypeTiny.noarch: W: spelling-error %description -l en_US isa -> is, visa, Lisa perl-MooX-TypeTiny.noarch: W: spelling-error %description -l en_US coercions -> coercion, coercion's, coercion s perl-MooX-TypeTiny.src: W: spelling-error %description -l en_US isa -> is, visa, Lisa perl-MooX-TypeTiny.src: W: spelling-error %description -l en_US coercions -> coercion, coercion's, coercion s 2 packages and 1 specfiles checked; 0 errors, 4 warnings. Rpmlint is ok Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items. Resolution: Approved
(In reply to Jitka Plesnikova from comment #1) > Source file is ok > Summary is ok > License is ok > Description is ok > URL and Source0 are ok > All tests passed > BuildRequires are ok > FIX: Please add BR > - perl(Moo::_Utils) - lib/MooX/TypeTiny.pm:7 The dependency is filtered from perl-Moo package, so it should not be added. > > $ rpm -qp --requires perl-MooX-TypeTiny-0.002003-1.fc36.noarch.rpm | sort | > uniq -c | grep -v rpmlib > 1 perl(:MODULE_COMPAT_5.34.0) > 1 perl(Moo::Role) > 1 perl(Moo::_Utils) FIX: Filter perl(Moo::_Utils) and require Moo which provide the module. > 1 perl(Scalar::Util) > 1 perl(strict) > 1 perl(Sub::Quote) > 1 perl(warnings) > FIX: Please add run-requires > - perl(Moo) >= 2.004000 > - perl(Type::Tiny) >= 1.008000 > > $ rpm -qp --provides perl-MooX-TypeTiny-0.002003-1.fc36.noarch.rpm | sort | > uniq -c > 1 perl(MooX::TypeTiny) = 0.002003 > 1 perl-MooX-TypeTiny = 0.002003-1.fc36 > 1 perl(MooX::TypeTiny::Role::GenerateAccessor) > Binary provides are Ok. > > $ rpmlint ./perl-MooX-TypeTiny* > perl-MooX-TypeTiny.noarch: W: spelling-error %description -l en_US isa -> > is, visa, Lisa > perl-MooX-TypeTiny.noarch: W: spelling-error %description -l en_US coercions > -> coercion, coercion's, coercion s > perl-MooX-TypeTiny.src: W: spelling-error %description -l en_US isa -> is, > visa, Lisa > perl-MooX-TypeTiny.src: W: spelling-error %description -l en_US coercions -> > coercion, coercion's, coercion s > 2 packages and 1 specfiles checked; 0 errors, 4 warnings. > Rpmlint is ok > > Otherwise the package is in line with Fedora and Perl packaging guide lines. > Please correct all 'FIX' items. > > Resolution: > Approved
(In reply to Jitka Plesnikova from comment #1) > > FIX: Please add run-requires > - perl(Moo) >= 2.004000 > - perl(Type::Tiny) >= 1.008000 Done. > FIX: Filter perl(Moo::_Utils) and require Moo which provide the module. Done. Spec URL: https://people.parinux.org/~seyman/fedora/perl-MooX-TypeTiny/perl-MooX-TypeTiny.spec SRPM URL: https://people.parinux.org/~seyman/fedora/perl-MooX-TypeTiny/perl-MooX-TypeTiny-0.002003-2.fc34.src.rpm > Resolution: > Approved Thank you for the review, Jikta!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-MooX-TypeTiny
Built for rawhide.