Bug 200310
| Summary: | Review Request: pyicq-t - ICQ transport for Jabber servers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jeffrey C. Ollie <jeff> |
| Component: | Package Review | Assignee: | Michael Fleming <mfleming+rpm> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mfleming+rpm |
| Target Milestone: | --- | Flags: | j:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-08-06 01:11:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Jeffrey C. Ollie
2006-07-26 19:51:46 UTC
Good:
+ Tar ball match with upstream.
+ Local build works fine.
+ No complaints for source rpm from rpmlint
+ No complaints for binaries rpm from rpmlint.
+ Mock build works fine.
Bad:
- Tar file has the name pyicq-t but the package is called pyicqt.
- when I start /etc/init.d/pyicqtt start, I will got the following message:
/etc/init.d/pyicqt start
Starting ICQ transport:
/usr/lib/python2.4/site-packages/twisted/words/__init__.py:21: UserWarning:
twisted.words will be undergoing a rewrite at some point in the future.
warnings.warn("twisted.words will be undergoing a rewrite at some point in the
future.")
(In reply to comment #1) > Good: > + Tar ball match with upstream. > + Local build works fine. > + No complaints for source rpm from rpmlint > + No complaints for binaries rpm from rpmlint. > + Mock build works fine. > > Bad: > - Tar file has the name pyicq-t but the package is called pyicqt. I'll change that in the next rev... > - when I start /etc/init.d/pyicqtt start, I will got the following message: > /etc/init.d/pyicqt start > Starting ICQ transport: > /usr/lib/python2.4/site-packages/twisted/words/__init__.py:21: UserWarning: > twisted.words will be undergoing a rewrite at some point in the future. > warnings.warn("twisted.words will be undergoing a rewrite at some point in the > future.") Yeah, I get that too. Until the pyicq-t authors update their code, I don't know what can be done, as this message is generated by twisted: [root@anim01 ~]# python Python 2.4.3 (#1, Jun 13 2006, 16:41:18) [GCC 4.0.2 20051125 (Red Hat 4.0.2-8)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import twisted.words /usr/lib/python2.4/site-packages/twisted/words/__init__.py:21: UserWarning: twisted.words will be undergoing a rewrite at some point in the future. warnings.warn("twisted.words will be undergoing a rewrite at some point in the future.") Updated twisted packages will be going into FE devel at some point; see Bug #171543 where you can find some release candidate packages to try. Spec: http://repo.ocjtech.us/misc/fedora/5/SRPMS/pyicq-t-0.7-2.fc5.spec SRPM: http://repo.ocjtech.us/misc/fedora/5/SRPMS/pyicq-t-0.7-2.fc5.src.rpm %changelog * Sun Jul 30 2006 Jeffrey C. Ollie <jeff> - 0.7-2 - Rename to pyicq-t - Change Group tag rpmlint dows complaints the following on the binary rpm: rpmlint pyicq-t-0.7-2.noarch.rpm E: pyicq-t obsolete-not-provided pyicqt W: pyicq-t incoherent-init-script-name pyicqt Spec: http://repo.ocjtech.us/misc/fedora/5/SRPMS/pyicq-t-0.7-3.fc5.spec SRPM: http://repo.ocjtech.us/misc/fedora/5/SRPMS/pyicq-t-0.7-3.fc5.src.rpm %changelog * Wed Aug 2 2006 Jeffrey C. Ollie <jeff> - 0.7-3 - Rename more stuff to pyicq-t I can approve your package. Thanks for the review! Imported and built for devel, branches requested for FC-4 and FC-5. Package Change Request ====================== Package Name: pyicq-t New Branches: EL-4 EL-5 Owners: mfleming CVS done. |