Bug 2004268

Summary: Review Request: perl-MooX-TypeTiny - Optimized type checks for Moo + Type::Tiny
Product: [Fedora] Fedora Reporter: Emmanuel Seyman <emmanuel>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: extras-qa, jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-09-17 12:49:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2001700    

Description Emmanuel Seyman 2021-09-14 21:08:32 UTC 
Spec URL: https://people.parinux.org/~seyman/fedora/perl-MooX-TypeTiny/perl-MooX-TypeTiny.spec
SRPM URL: https://people.parinux.org/~seyman/fedora/perl-MooX-TypeTiny/perl-MooX-TypeTiny-0.002003-1.fc34.src.rpm
Description:
This module optimizes Moo type checks when used with Type::Tiny to perform
better. It will automatically apply to isa checks and coercions that use
Type::Tiny. Non-Type::Tiny isa checks will work as normal.

Fedora Account System Username: eseyman
Rpmlint Output:
perl-MooX-TypeTiny.src: W: spelling-error %description -l en_US isa -> is, visa, Lisa
perl-MooX-TypeTiny.src: W: spelling-error %description -l en_US coercions -> coercion, coercion's, coercion s
1 packages and 1 specfiles checked; 0 errors, 2 warnings.
Comment 1 Jitka Plesnikova 2021-09-16 10:44:07 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok
FIX: Please add BR 
     - perl(Moo::_Utils) - lib/MooX/TypeTiny.pm:7

$ rpm -qp --requires perl-MooX-TypeTiny-0.002003-1.fc36.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(:MODULE_COMPAT_5.34.0)
      1 perl(Moo::Role)
      1 perl(Moo::_Utils)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Sub::Quote)
      1 perl(warnings)
FIX: Please add run-requires
     - perl(Moo) >= 2.004000
     - perl(Type::Tiny) >= 1.008000

$ rpm -qp --provides perl-MooX-TypeTiny-0.002003-1.fc36.noarch.rpm | sort | uniq -c
      1 perl(MooX::TypeTiny) = 0.002003
      1 perl-MooX-TypeTiny = 0.002003-1.fc36
      1 perl(MooX::TypeTiny::Role::GenerateAccessor)
Binary provides are Ok.

$ rpmlint ./perl-MooX-TypeTiny*
perl-MooX-TypeTiny.noarch: W: spelling-error %description -l en_US isa -> is, visa, Lisa
perl-MooX-TypeTiny.noarch: W: spelling-error %description -l en_US coercions -> coercion, coercion's, coercion s
perl-MooX-TypeTiny.src: W: spelling-error %description -l en_US isa -> is, visa, Lisa
perl-MooX-TypeTiny.src: W: spelling-error %description -l en_US coercions -> coercion, coercion's, coercion s
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Rpmlint is ok

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items. 

Resolution:
Approved
Comment 2 Jitka Plesnikova 2021-09-16 10:51:13 UTC 
(In reply to Jitka Plesnikova from comment #1)
> Source file is ok
> Summary is ok
> License is ok
> Description is ok
> URL and Source0 are ok
> All tests passed
> BuildRequires are ok
> FIX: Please add BR 
>      - perl(Moo::_Utils) - lib/MooX/TypeTiny.pm:7
The dependency is filtered from perl-Moo package, so it should not be added.

> 
> $ rpm -qp --requires perl-MooX-TypeTiny-0.002003-1.fc36.noarch.rpm | sort |
> uniq -c | grep -v rpmlib
>       1 perl(:MODULE_COMPAT_5.34.0)
>       1 perl(Moo::Role)
>       1 perl(Moo::_Utils)
FIX: Filter perl(Moo::_Utils) and require Moo which provide the module.

>       1 perl(Scalar::Util)
>       1 perl(strict)
>       1 perl(Sub::Quote)
>       1 perl(warnings)
> FIX: Please add run-requires
>      - perl(Moo) >= 2.004000
>      - perl(Type::Tiny) >= 1.008000
> 
> $ rpm -qp --provides perl-MooX-TypeTiny-0.002003-1.fc36.noarch.rpm | sort |
> uniq -c
>       1 perl(MooX::TypeTiny) = 0.002003
>       1 perl-MooX-TypeTiny = 0.002003-1.fc36
>       1 perl(MooX::TypeTiny::Role::GenerateAccessor)
> Binary provides are Ok.
> 
> $ rpmlint ./perl-MooX-TypeTiny*
> perl-MooX-TypeTiny.noarch: W: spelling-error %description -l en_US isa ->
> is, visa, Lisa
> perl-MooX-TypeTiny.noarch: W: spelling-error %description -l en_US coercions
> -> coercion, coercion's, coercion s
> perl-MooX-TypeTiny.src: W: spelling-error %description -l en_US isa -> is,
> visa, Lisa
> perl-MooX-TypeTiny.src: W: spelling-error %description -l en_US coercions ->
> coercion, coercion's, coercion s
> 2 packages and 1 specfiles checked; 0 errors, 4 warnings.
> Rpmlint is ok
> 
> Otherwise the package is in line with Fedora and Perl packaging guide lines.
> Please correct all 'FIX' items. 
> 
> Resolution:
> Approved
Comment 3 Emmanuel Seyman 2021-09-16 19:40:28 UTC 
(In reply to Jitka Plesnikova from comment #1)
> 
> FIX: Please add run-requires
>      - perl(Moo) >= 2.004000
>      - perl(Type::Tiny) >= 1.008000

Done.

> FIX: Filter perl(Moo::_Utils) and require Moo which provide the module.

Done.

Spec URL: https://people.parinux.org/~seyman/fedora/perl-MooX-TypeTiny/perl-MooX-TypeTiny.spec
SRPM URL: https://people.parinux.org/~seyman/fedora/perl-MooX-TypeTiny/perl-MooX-TypeTiny-0.002003-2.fc34.src.rpm

> Resolution:
> Approved

Thank you for the review, Jikta!
Comment 4 Gwyn Ciesla 2021-09-16 21:00:41 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-MooX-TypeTiny
Comment 5 Emmanuel Seyman 2021-09-17 12:49:42 UTC 
Built for rawhide.