Bug 2005328 (qt6-qtlocation)

Summary:	Review Request: qt6-qtlocation - Location component
Product:	[Fedora] Fedora	Reporter:	Jan Grulich <jgrulich>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-09-17 15:13:41 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1917559

Description Jan Grulich 2021-09-17 12:57:34 UTC

Spec URL: https://jgrulich.fedorapeople.org/qt6/qt6-qtlocation/qt6-qtlocation.spec
SRPM URL: https://jgrulich.fedorapeople.org/qt6/qt6-qtlocation/qt6-qtlocation-6.2.0~beta4-1.fc35.src.rpm
Description: The Qt Location and Qt Positioning APIs gives developers the ability to determine a position by using a variety of possible sources, including
satellite, or wifi, or text file, and so on.
Fedora Account System Username: jgrulich

Comment 1 Neal Gompa 2021-09-17 17:20:04 UTC

Taking this review.

Comment 2 Neal Gompa 2021-09-17 17:20:44 UTC

> BuildRequires: qt6-qtlocation-devel >= %{version}

I don't know how we're supposed to build this package?

Comment 3 Jan Grulich 2021-09-18 17:57:01 UTC

Fixed. I added a wrong dependency. 

Spec URL: https://jgrulich.fedorapeople.org/qt6/qt6-qtlocation/qt6-qtlocation.spec
SRPM URL: https://jgrulich.fedorapeople.org/qt6/qt6-qtlocation/qt6-qtlocation-6.2.0~beta4-1.fc35.src.rpm
Description: The Qt Location and Qt Positioning APIs gives developers the ability to determine a position by using a variety of possible sources, including
satellite, or wifi, or text file, and so on.
Fedora Account System Username: jgrulich

Comment 4 Neal Gompa 2021-09-18 18:15:05 UTC

Review notes:

* Package is named correctly
* Package follows proper conventions for Qt packages
* Package builds and installs (once all dependencies are in the buildroot)
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 5 Igor Raits 2021-09-20 10:56:36 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6-qtlocation

Comment 6 Package Review 2022-09-17 15:13:41 UTC

Package is now in repositories, closing review.