Bug 2005328 (qt6-qtlocation) - Review Request: qt6-qtlocation - Location component
Summary: Review Request: qt6-qtlocation - Location component
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: qt6-qtlocation
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: qt6-reviews
TreeView+ depends on / blocked
 
Reported: 2021-09-17 12:57 UTC by Jan Grulich
Modified: 2022-09-17 15:13 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-09-17 15:13:41 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Jan Grulich 2021-09-17 12:57:34 UTC
Spec URL: https://jgrulich.fedorapeople.org/qt6/qt6-qtlocation/qt6-qtlocation.spec
SRPM URL: https://jgrulich.fedorapeople.org/qt6/qt6-qtlocation/qt6-qtlocation-6.2.0~beta4-1.fc35.src.rpm
Description: The Qt Location and Qt Positioning APIs gives developers the ability to determine a position by using a variety of possible sources, including
satellite, or wifi, or text file, and so on.
Fedora Account System Username: jgrulich

Comment 1 Neal Gompa 2021-09-17 17:20:04 UTC
Taking this review.

Comment 2 Neal Gompa 2021-09-17 17:20:44 UTC
> BuildRequires: qt6-qtlocation-devel >= %{version}

I don't know how we're supposed to build this package?

Comment 3 Jan Grulich 2021-09-18 17:57:01 UTC
Fixed. I added a wrong dependency. 

Spec URL: https://jgrulich.fedorapeople.org/qt6/qt6-qtlocation/qt6-qtlocation.spec
SRPM URL: https://jgrulich.fedorapeople.org/qt6/qt6-qtlocation/qt6-qtlocation-6.2.0~beta4-1.fc35.src.rpm
Description: The Qt Location and Qt Positioning APIs gives developers the ability to determine a position by using a variety of possible sources, including
satellite, or wifi, or text file, and so on.
Fedora Account System Username: jgrulich

Comment 4 Neal Gompa 2021-09-18 18:15:05 UTC
Review notes:

* Package is named correctly
* Package follows proper conventions for Qt packages
* Package builds and installs (once all dependencies are in the buildroot)
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 5 Igor Raits 2021-09-20 10:56:36 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6-qtlocation

Comment 6 Package Review 2022-09-17 15:13:41 UTC
Package is now in repositories, closing review.


Note You need to log in before you can comment on or make changes to this bug.