Bug 2008431

Summary: smbios hook is incompatible with python3
Product: [oVirt] vdsm Reporter: Konstantin Kuzov <master.nosferatu>
Component: GeneralAssignee: Filip Januška <fjanuska>
Status: CLOSED CURRENTRELEASE QA Contact: Lukas Svaty <lsvaty>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.40.80.6CC: ahadas, bugs, michal.skrivanek, mzamazal
Target Milestone: ovirt-4.4.9Keywords: Regression
Target Release: ---Flags: pm-rhel: ovirt-4.5?
michal.skrivanek: blocker-
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: vdsm-4.40.90.2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-10-07 08:34:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
vdsm-hook-smbios python3 iterators patch none

Description Konstantin Kuzov 2021-09-28 08:41:16 UTC
Created attachment 1826907 [details]
vdsm-hook-smbios python3 iterators patch

Description of problem:
The commit 37a76555de906396dc1c0c46434fe9b2542f456f just changes python2 interpreter to python3 without porting python2-only iterators to python3.

Steps to Reproduce:
1. Create VM with smbios hook custom properties
2. Try to start VM

Actual results:
Hook errors out during execution in before_vm_start and VM subsequently doesn't start.

Expected results:
VM is starting successfully and apply specified smbios properties

Additional info:
Attached patch fixes the problem.

Comment 1 RHEL Program Management 2021-09-28 14:00:09 UTC
The documentation text flag should only be set after 'doc text' field is provided. Please provide the documentation text and set the flag to '?' again.

Comment 2 RHEL Program Management 2021-09-29 06:46:08 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 5 Sandro Bonazzola 2021-10-21 07:29:31 UTC
This bugzilla is included in oVirt 4.4.9 release, published on October 20th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.9 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.