Bug 2008431 - smbios hook is incompatible with python3
Summary: smbios hook is incompatible with python3
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: General
Version: 4.40.80.6
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.4.9
: ---
Assignee: Filip Januška
QA Contact: Lukas Svaty
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-09-28 08:41 UTC by Konstantin Kuzov
Modified: 2021-11-04 19:28 UTC (History)
4 users (show)

Fixed In Version: vdsm-4.40.90.2
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-10-07 08:34:18 UTC
oVirt Team: Virt
Embargoed:
pm-rhel: ovirt-4.5?
michal.skrivanek: blocker-


Attachments (Terms of Use)
vdsm-hook-smbios python3 iterators patch (996 bytes, patch)
2021-09-28 08:41 UTC, Konstantin Kuzov
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHV-43712 0 None None None 2021-09-28 08:43:16 UTC
oVirt gerrit 116870 0 master MERGED build: Replace deprecated 'iterkeys()' 2021-10-06 12:57:04 UTC
oVirt gerrit 117014 0 ovirt-4.4.z MERGED build: Replace deprecated 'iterkeys()' 2021-10-07 08:28:31 UTC

Description Konstantin Kuzov 2021-09-28 08:41:16 UTC
Created attachment 1826907 [details]
vdsm-hook-smbios python3 iterators patch

Description of problem:
The commit 37a76555de906396dc1c0c46434fe9b2542f456f just changes python2 interpreter to python3 without porting python2-only iterators to python3.

Steps to Reproduce:
1. Create VM with smbios hook custom properties
2. Try to start VM

Actual results:
Hook errors out during execution in before_vm_start and VM subsequently doesn't start.

Expected results:
VM is starting successfully and apply specified smbios properties

Additional info:
Attached patch fixes the problem.

Comment 1 RHEL Program Management 2021-09-28 14:00:09 UTC
The documentation text flag should only be set after 'doc text' field is provided. Please provide the documentation text and set the flag to '?' again.

Comment 2 RHEL Program Management 2021-09-29 06:46:08 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 5 Sandro Bonazzola 2021-10-21 07:29:31 UTC
This bugzilla is included in oVirt 4.4.9 release, published on October 20th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.9 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.