Bug 2009494

Summary:	Review Request: golang-github-itchyny-timefmt - Efficient time formatting library (strftime, strptime) for Golang
Product:	[Fedora] Fedora	Reporter:	Mikel Olasagasti Uranga <mikel>
Component:	Package Review	Assignee:	Maxwell G <maxwell>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	maxwell, package-review, sanne.raymaekers
Target Milestone:	---	Flags:	maxwell: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-12-06 20:06:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1803302, 2009498, 2010367

Description Mikel Olasagasti Uranga 2021-09-30 19:21:19 UTC

Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-itchyny-timefmt.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-itchyny-timefmt-0.1.3-1.fc34.src.rpm
Description: Efficient time formatting library (strftime, strptime) for Golang
Fedora Account System Username: mikelo2

Comment 1 Maxwell G 2021-12-05 04:36:53 UTC

I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- The specfile is sane.
- License is correct
- Builds successfully in mock
- All rpmlint errors are spurious
- %check section passes

Package approved!

Comment 2 Maxwell G 2021-12-05 04:44:10 UTC

Also:

When you import this package, don't forget to add `Fixes rhbz#2009494` to the rpm changelog and/or manually add this bug to the Bodhi update so it gets marked as CLOSED. I added your package to Antiya/release-monitoring.org[1]. I think you should give go-sig admin privileges when the package is
imported, as well.

[1]: https://release-monitoring.org/project/241511/

Comment 3 Maxwell G 2021-12-05 05:47:58 UTC

*** Bug 2028443 has been marked as a duplicate of this bug. ***

Comment 4 Tomas Hrcka 2021-12-06 10:55:59 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-itchyny-timefmt

Comment 5 Fedora Update System 2021-12-06 20:04:29 UTC

FEDORA-2021-924ce8cdb7 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-924ce8cdb7

Comment 6 Fedora Update System 2021-12-06 20:05:15 UTC

FEDORA-2021-ea5215324c has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-ea5215324c

Comment 7 Mikel Olasagasti Uranga 2021-12-06 20:06:24 UTC

Thanks for the review Maxwell!

I added go-sig as co-admin for the package.