Bug 1803302 - Review Request: github-cli - The GitHub CLI
Summary: Review Request: github-cli - The GitHub CLI
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1803303 1803309 1803310 1803311 1803312 1805482
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-15 04:29 UTC by Joe Doss
Modified: 2020-10-16 16:17 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---


Attachments (Terms of Use)

Comment 2 Robert-André Mauchin 🐧 2020-02-16 23:45:42 UTC
 - Not needed:

%global tag             v0.5.5
%global distprefix      %{nil}

- Install fails:

DEBUG util.py:584:  Error: 
DEBUG util.py:584:   Problem: conflicting requests
DEBUG util.py:584:    - nothing provides golang(github.com/AlecAivazis/survey/v2) needed by golang-github-cli-devel-0.5.5-1.fc33.noarch
DEBUG util.py:584:    - nothing provides golang(github.com/AlecAivazis/survey/v2/terminal) needed by golang-github-cli-devel-0.5.5-1.fc33.noarch

 Since we don't support modules fix it in prep with:

sed -i "s|github.com/AlecAivazis/survey/v2|github.com/AlecAivazis/survey|" $(find . -name "*.go")

Comment 3 Omair Majid 2020-02-17 19:13:30 UTC
Drive-by suggestion: Can you use SOURCE_DATE_EPOCH instead of $(date +%Y-%m-%d)? That would make this build more reproducible.

Comment 4 Joe Doss 2020-02-20 21:23:29 UTC
(In reply to Omair Majid from comment #3)
> Drive-by suggestion: Can you use SOURCE_DATE_EPOCH instead of $(date
> +%Y-%m-%d)? That would make this build more reproducible.

Thanks for this Omair. Updated my spec to use SOURCE_DATE_EPOCH.


GitHub released 0.5.6 already with another dependency that has two other dependencies. https://bugzilla.redhat.com/show_bug.cgi?id=1805482 is one of them. I am having trouble building the other which I emailed Robert-André off BZ to figure out how to handle/package. I will update this BZ with the updated spec and srpm once that is sorted out.

Comment 5 Vitaly Zaitsev 2020-09-17 17:26:17 UTC
Version 1.0 was released. Any progress on this?

Comment 6 Joe Doss 2020-09-22 21:58:53 UTC
(In reply to Vitaly Zaitsev from comment #5)
> Version 1.0 was released. Any progress on this?


Now that 1.0 is out and hopefully the dependencies have stabilize so I can get this out the door. I will try and work on it over the next week or so.

Comment 7 Rich Megginson 2020-09-29 17:20:20 UTC
Note - this is a replacement for the `hub` command which is being deprecated

Comment 8 Joe Doss 2020-10-16 16:17:06 UTC
OK let's try this again. Here is the spec and srpm for GitHub CLI 1.1.0

Spec URL: https://download.copr.fedorainfracloud.org/results/jdoss/github-cli/fedora-33-x86_64/01709946-github-cli/github-cli.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/jdoss/github-cli/fedora-33-x86_64/01709946-github-cli/github-cli-1.1.0-1.fc33.src.rpm

Description: GitHub's official command line tool

Fedora Account System Username: jdoss


And the eleven dependency packages review requests:

golang-github-netflix-expect
https://bugzilla.redhat.com/show_bug.cgi?id=1803309

golang-github-hinshun-vt10x
https://bugzilla.redhat.com/show_bug.cgi?id=1803312

golang-github-alecaivazis-survey
https://bugzilla.redhat.com/show_bug.cgi?id=1803303

golang-github-muesli-reflow
https://bugzilla.redhat.com/show_bug.cgi?id=1888965

golang-github-muesli-termenv
https://bugzilla.redhat.com/show_bug.cgi?id=1888966

golang-github-charmbracelet-glamour 
https://bugzilla.redhat.com/show_bug.cgi?id=1888967

golang-github-henvic-httpretty
https://bugzilla.redhat.com/show_bug.cgi?id=1888968

golang-github-rivo-uniseg
https://bugzilla.redhat.com/show_bug.cgi?id=1888970

golang-github-cli-shurcool-graphql
https://bugzilla.redhat.com/show_bug.cgi?id=1888971

golang-github-shurcool-githubv4
https://bugzilla.redhat.com/show_bug.cgi?id=1888972

golang-github-enescakir-emoji
https://bugzilla.redhat.com/show_bug.cgi?id=1888974


Note You need to log in before you can comment on or make changes to this bug.