Bug 2011908

Summary: Review Request: Pywaffle - Add it on fedora
Product: [Fedora] Fedora Reporter: Persona non grata <nobody+465741>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: code, mattdm, package-review, zbyszek
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-12-17 01:21:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Persona non grata 2021-10-07 17:29:38 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/itotutona/Pywaffle/fedora-34-aarch64/02877524-python-pywaffle/python-pywaffle.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/itotutona/Pywaffle/fedora-34-aarch64/02877524-python-pywaffle/python-pywaffle-0.6.3-1.fc34.src.rpm
Description: Introduction PyWaffle is an open source, MIT-licensed Python package for
plotting waffle charts.It provides a Figure constructor class < Waffle, which
could be passed to matplotlib.pyplot.figure < and generates a matplotlib Figure
object.
Fedora Account System Username: Itotutona
Comment 1 Ben Beasley 2021-10-09 14:26:31 UTC 
Some preliminary notes:

  - It would be great to package this under the new Python guidelines
    (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/),
    using pyproject-rpm-macros.

  - You can’t bundle font files
    (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_avoid_bundling_of_fonts_in_other_packages).

    You’ll have to figure out how to get
    https://src.fedoraproject.org/rpms/fontawesome5-fonts
    to provide the necessary fonts in OpenType format according to
    https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/
    and then patch pywaffle to use the system-wide versions.

    This is a huge pain, but there isn’t really any way around it.

  - Your Summary should be shortened to less than 80 characters.

  - You should remove shebang lines from pywaffle/*.py, since they are
    not executable and not suitable for use as scripts. Preferably, send
    a patch or PR upstream for this.
Comment 2 Ben Beasley 2021-10-09 14:27:48 UTC 
Also — please change the title of this issue to match the package name and summary in the spec file (“python-pywaffle - my less than 80 character summary goes here”).
Comment 3 Zbigniew Jędrzejewski-Szmek 2021-11-21 13:29:48 UTC 
%description has some strange chars inserted…
Comment 4 Matthew Miller 2021-12-16 19:27:22 UTC 
Looks like this is dead. Oh well! I'm going to close it and open a new one.
Comment 5 Matthew Miller 2021-12-17 01:20:40 UTC 
New package review request at 2033481
Comment 6 Matthew Miller 2021-12-17 01:21:25 UTC 
#2033481

*** This bug has been marked as a duplicate of bug 2033481 ***