Bug 2011908 - Review Request: Pywaffle - Add it on fedora
Summary: Review Request: Pywaffle - Add it on fedora
Keywords:
Status: CLOSED DUPLICATE of bug 2033481
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-10-07 17:29 UTC by Persona non grata
Modified: 2021-12-17 01:21 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-12-17 01:21:25 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Persona non grata 2021-10-07 17:29:38 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/itotutona/Pywaffle/fedora-34-aarch64/02877524-python-pywaffle/python-pywaffle.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/itotutona/Pywaffle/fedora-34-aarch64/02877524-python-pywaffle/python-pywaffle-0.6.3-1.fc34.src.rpm
Description: Introduction PyWaffle is an open source, MIT-licensed Python package for
plotting waffle charts.It provides a Figure constructor class < Waffle, which
could be passed to matplotlib.pyplot.figure < and generates a matplotlib Figure
object.
Fedora Account System Username: Itotutona

Comment 1 Ben Beasley 2021-10-09 14:26:31 UTC
Some preliminary notes:

  - It would be great to package this under the new Python guidelines
    (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/),
    using pyproject-rpm-macros.

  - You can’t bundle font files
    (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_avoid_bundling_of_fonts_in_other_packages).

    You’ll have to figure out how to get
    https://src.fedoraproject.org/rpms/fontawesome5-fonts
    to provide the necessary fonts in OpenType format according to
    https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/
    and then patch pywaffle to use the system-wide versions.

    This is a huge pain, but there isn’t really any way around it.

  - Your Summary should be shortened to less than 80 characters.

  - You should remove shebang lines from pywaffle/*.py, since they are
    not executable and not suitable for use as scripts. Preferably, send
    a patch or PR upstream for this.

Comment 2 Ben Beasley 2021-10-09 14:27:48 UTC
Also — please change the title of this issue to match the package name and summary in the spec file (“python-pywaffle - my less than 80 character summary goes here”).

Comment 3 Zbigniew Jędrzejewski-Szmek 2021-11-21 13:29:48 UTC
%description has some strange chars inserted…

Comment 4 Matthew Miller 2021-12-16 19:27:22 UTC
Looks like this is dead. Oh well! I'm going to close it and open a new one.

Comment 5 Matthew Miller 2021-12-17 01:20:40 UTC
New package review request at 2033481

Comment 6 Matthew Miller 2021-12-17 01:21:25 UTC
#2033481

*** This bug has been marked as a duplicate of bug 2033481 ***


Note You need to log in before you can comment on or make changes to this bug.