Bug 2013127
| Summary: | OperatorHub links could not be opened in a new tabs (sharing and open a deep link works fine) | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Christoph Jerolimov <cjerolim> |
| Component: | Management Console | Assignee: | Robb Hamilton <rhamilto> |
| Status: | CLOSED ERRATA | QA Contact: | Yanping Zhang <yanpzhan> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 4.8 | CC: | aos-bugs, jhadvig, yapei |
| Target Milestone: | --- | ||
| Target Release: | 4.10.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Cause: OperatorHub category and card links do not include valid href attributes.
Consequence: OperatorHub category and card links cannot be opened in a new tab.
Fix: Add valid href attributes to OperatorHub category and card links.
Result: OperatorHub category and card links can be opened in a new tab.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-03-10 16:18:42 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Christoph Jerolimov
2021-10-12 07:54:37 UTC
fyi: I expect that the onClick handler needs a `if (isModifiedEvent(e)) return;` check, similar to https://github.com/openshift/console/pull/9257/files so that ctrl+click just opens a new page and do not change the active tab. Re-assigning due to Maude's transfer to OCM team. > - https://issues.redhat.com/browse/ODC-6038 fixed in https://github.com/openshift/console/pull/9287 I noticed this only fixed the issue for the Type filters. The primary filters ("All items", "CI/CD", etc.) cannot be ctrl/cmd + clicked or right clicked and opened in a new window. That is because the VerticalTabs component in use there is from @patternfly/react-catalog-view-extension which does not have the fix applied in https://github.com/patternfly/patternfly-react/pull/6072 as that only applies to @patternfly/react-core. > I noticed this only fixed the issue for the Type filters. The primary filters ("All items", "CI/CD", etc.) cannot be ctrl/cmd + clicked or right clicked and opened in a new window. That is because the VerticalTabs component in use there is from @patternfly/react-catalog-view-extension which does not have the fix applied in https://github.com/patternfly/patternfly-react/pull/6072 as that only applies to @patternfly/react-core.
Whoops. Disregard. Looking at the wrong tab!
Checked on ocp 4.10 cluster with payload 4.10.0-0.nightly-2022-01-24-070025, go to Operators > OperatorHub page, right click on an vertical tab like "Databases" or "Monitoring" or a card like "Advanced Cluster Security for Kubernetes", all could open correct page in a new tab. The bug is fixed. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2022:0056 |