Bug 2013127 - OperatorHub links could not be opened in a new tabs (sharing and open a deep link works fine)
Summary: OperatorHub links could not be opened in a new tabs (sharing and open a deep ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.8
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: 4.10.0
Assignee: Robb Hamilton
QA Contact: Yanping Zhang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-10-12 07:54 UTC by Christoph Jerolimov
Modified: 2022-03-10 16:19 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: OperatorHub category and card links do not include valid href attributes. Consequence: OperatorHub category and card links cannot be opened in a new tab. Fix: Add valid href attributes to OperatorHub category and card links. Result: OperatorHub category and card links can be opened in a new tab.
Clone Of:
Environment:
Last Closed: 2022-03-10 16:18:42 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 10853 0 None open [WIP] Bug 2013127: allow catalog categories and cards to open in new tab 2022-01-14 22:21:03 UTC
Red Hat Product Errata RHSA-2022:0056 0 None None None 2022-03-10 16:19:09 UTC

Description Christoph Jerolimov 2021-10-12 07:54:37 UTC
Description of problem:
Users which inspects the OperatorHub could not open one of the categories (vertical tab items) like "Databases" or "Monitoring" and cards in a new tab.

Right click > open in new tabs opens the admin dashboard (because it opens just /#)

Ctrl+click doesn't work at all.


Background infos:
This issue is similar to ODC issues in developer catalog
- https://issues.redhat.com/browse/ODC-6038 fixed in https://github.com/openshift/console/pull/9287
- https://issues.redhat.com/browse/ODC-6032 fixed in https://github.com/openshift/console/pull/9257

The behaviour that a vertical tab item should not open #/ when the user ctrl+clicks was reported by us and changed in this PatternFly PR:
- https://github.com/patternfly/patternfly-react/issues/5957
- https://github.com/patternfly/patternfly-react/pull/6072


Version-Release number of selected component (if applicable):
4.7 untested
4.8 opens the wrong page or nothing


How reproducible:
Always


Steps to Reproduce:
1. Open the admin perspective and navigate to Operators > OperatorHub
2. Try to right click > open in new tab or ctrl+click a category or source


Actual results:
Open the wrong page do nothing

Expected results:
Should open the category in a new tab

Additional info:
None

Comment 1 Christoph Jerolimov 2021-10-14 08:25:02 UTC
fyi: I expect that the onClick handler needs a `if (isModifiedEvent(e)) return;` check, similar to https://github.com/openshift/console/pull/9257/files so that ctrl+click just opens a new page and do not change the active tab.

Comment 3 Jakub Hadvig 2022-01-14 06:33:05 UTC
Re-assigning due to Maude's transfer to OCM team.

Comment 4 Robb Hamilton 2022-01-14 16:22:06 UTC
> - https://issues.redhat.com/browse/ODC-6038 fixed in https://github.com/openshift/console/pull/9287

I noticed this only fixed the issue for the Type filters.  The primary filters ("All items", "CI/CD", etc.) cannot be ctrl/cmd + clicked or right clicked and opened in a new window.  That is because the VerticalTabs component in use there is from @patternfly/react-catalog-view-extension which does not have the fix applied in https://github.com/patternfly/patternfly-react/pull/6072 as that only applies to @patternfly/react-core.

Comment 5 Robb Hamilton 2022-01-14 16:30:52 UTC
> I noticed this only fixed the issue for the Type filters.  The primary filters ("All items", "CI/CD", etc.) cannot be ctrl/cmd + clicked or right clicked and opened in a new window.  That is because the VerticalTabs component in use there is from @patternfly/react-catalog-view-extension which does not have the fix applied in https://github.com/patternfly/patternfly-react/pull/6072 as that only applies to @patternfly/react-core.

Whoops.  Disregard.  Looking at the wrong tab!

Comment 8 Yanping Zhang 2022-01-25 03:16:57 UTC
Checked on ocp 4.10 cluster with payload 4.10.0-0.nightly-2022-01-24-070025, go to  Operators > OperatorHub page, right click on an vertical tab like "Databases" or "Monitoring" or a card like "Advanced Cluster Security for Kubernetes", all could open correct page in a new tab. 
The bug is fixed.

Comment 11 errata-xmlrpc 2022-03-10 16:18:42 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056


Note You need to log in before you can comment on or make changes to this bug.