Bug 201533

Description of problem:

hal apparently does not handle at least an IDE DVD-ROM/CD-RW drive which is
being driven by libata using the libata PATA patch. I assume this would also
affect any other optical drives using the sr driver (SATA, SCSI, USB) as well.

Specifically it doesn't seem to be recognized as a CD drive by HAL, and discs
are not automatically mounted as they should be. lshal shows this part when the
drive is being driven by IDE (as /dev/hdc) but not when being driven by libata
(as /dev/scd0):

udi = '/org/freedesktop/Hal/devices/storage_model_QSI_CD_RW/DVD_ROM_SBW_241'
  info.addons = {'hald-addon-storage'} (string list)
  block.storage_device =
'/org/freedesktop/Hal/devices/storage_model_QSI_CD_RW/DVD_ROM_SBW_241'  (string)
  info.udi =
'/org/freedesktop/Hal/devices/storage_model_QSI_CD_RW/DVD_ROM_SBW_241'  (string)
  storage.cdrom.write_speed = 4236  (0x108c)  (int)
  storage.cdrom.read_speed = 4224  (0x1080)  (int)
  storage.cdrom.support_media_changed = true  (bool)
  storage.cdrom.hddvdrw = false  (bool)
  storage.cdrom.hddvdr = false  (bool)
  storage.cdrom.hddvd = false  (bool)
  storage.cdrom.bdre = false  (bool)
  storage.cdrom.bdr = false  (bool)
  storage.cdrom.bd = false  (bool)
  storage.cdrom.dvdplusrdl = false  (bool)
  storage.cdrom.dvdplusrw = false  (bool)
  storage.cdrom.dvdplusr = false  (bool)
  storage.cdrom.dvdram = false  (bool)
  storage.cdrom.dvdrw = false  (bool)
  storage.cdrom.dvdr = false  (bool)
  storage.cdrom.dvd = true  (bool)
  storage.cdrom.cdrw = true  (bool)
  storage.cdrom.cdr = true  (bool)
  storage.requires_eject = true  (bool)
  storage.hotpluggable = false  (bool)
  info.capabilities = {'storage', 'block', 'storage.cdrom'} (string list)
  info.category = 'storage'  (string)
  info.product = 'QSI CD-RW/DVD-ROM SBW-241'  (string)
  storage.removable = true  (bool)
  storage.physical_device = '/org/freedesktop/Hal/devices/pci_8086_24ca_ide_1_0'
 (string)
  storage.firmware_version = 'VH04'  (string)
  storage.vendor = ''  (string)
  storage.model = 'QSI CD-RW/DVD-ROM SBW-241'  (string)
  storage.drive_type = 'cdrom'  (string)
  storage.automount_enabled_hint = true  (bool)
  storage.media_check_enabled = true  (bool)
  storage.no_partitions_hint = true  (bool)
  storage.bus = 'ide'  (string)
  block.is_volume = false  (bool)
  block.minor = 0  (0x0)  (int)
  block.major = 22  (0x16)  (int)
  block.device = '/dev/hdc'  (string)
  linux.hotplug_type = 3  (0x3)  (int)
  info.parent = '/org/freedesktop/Hal/devices/pci_8086_24ca_ide_1_0'  (string)
  linux.sysfs_path_device = '/sys/block/hdc'  (string)
  linux.sysfs_path = '/sys/block/hdc'  (string)

With libata this entire section is missing from the output.

Version-Release number of selected component (if applicable):

hal-0.5.7.1-2.fc5

How reproducible:

Every time

Steps to Reproduce:
1. Run FC5 on a system using a CD/DVD drive being driven by the sr driver
2. 
3.
  
Actual results:

CDs/DVDs are not auto-mounted when inserted.

Expected results:

CDs/DVDs should be auto-mounted as they are when a drive is being driven by ide-cd.

Additional info:

From what I can tell it seems that hal is getting confused. From the hal verbose
output with IDE:

01:04:16.396 [I] hotplug.c:208: /sys/block/hdc is a block device (devpath)
01:04:16.396 [I] blockdev.c:637: block_add: sysfs_path=/sys/block/hdc
dev=/dev/hdc is_part=0, parent=0x08b8bca8
01:04:16.396 [I] blockdev.c:867: parent_bus is ide
01:04:16.397 [I] blockdev.c:492: Probing storage device /dev/hdc

and with libata:

00:55:32.188 [I] hotplug.c:208: /sys/block/sr0 is a block device (devpath)
00:55:32.188 [I] blockdev.c:637: block_add: sysfs_path=/sys/block/sr0
dev=/dev/scd0 is_part=1, parent=0x00000000
00:55:32.189 [I] blockdev.c:547: get_luks_uuid: device_file=/dev/scd0
00:55:32.189 [I] blockdev.c:673: Ignoring hotplug event - no parent
00:55:32.189 [W] blockdev.c:1043: Not adding device object

Note that is_part is set to 1. Looking at the code in HAL hotplug.c to detect
this flag:

is_partition = isdigit(hotplug_event->sysfs.sysfs_path[len - 1]) ||
       strstr (hotplug_event->sysfs.sysfs_path, "/fakevolume") ;

In other words it assumes the device node is a partition if it ends with a
number. This is clearly wrong as it will think that /dev/scd0 is a partition
when it is an entire device. This seems to be causing HAL to get confused and
not handle the device properly.

This was changed in the hal git repository just recently (since 0.5.7.1) such
that it no longer appears to make this invalid assumption:

http://gitweb.freedesktop.org/?p=hal;a=commit;h=963aa432d16ba81c3f5c404a02b8a5befef7521d
http://gitweb.freedesktop.org/?p=hal;a=commit;h=57a4df10e1d8d2919d2fc2ad358bbfd0de702953

However I have no way of easily testing whether these changes actually fix the
problem..