Bug 2018847
| Summary: | Review Request: python-param - Make your Python code clearer and more reliable by declaring Parameters | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Beasley <code> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-12-02 01:14:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2019157, 2022153 | ||
|
Description
Ben Beasley
2021-11-01 00:07:41 UTC
(In reply to Ben Beasley from comment #0) > Param contains only two required Python files, with no external dependencies, > and is provided freely for both non-commercial and commercial use under a BSD > license, so that it can easily be included as part of other projects. > > Please see param’s website (https://param.holoviz.org/) for official > releases, > installation instructions, documentation, and examples. Those two paragraphs are not relevant to Fedora users, who don't need to care about packaging or upstream installation instructions. Maybe just leave the link to the upstream website? + package name is OK + license is acceptable (BSD) + license is specified correctly + latest version (there's a new alpha release, but we don't need that) + standard template with pyproject macros is used + BR/R/P look OK + builds and installs OK rpmlint: python3-param.noarch: W: no-documentation python3-param.noarch: W: hidden-file-or-dir /usr/lib/python3.10/site-packages/param/.version python-param.src: W: strange-permission python-param.spec 600 3 packages and 0 specfiles checked; 0 errors, 3 warnings. All OK, I guess. Package is APPROVED. Thanks for the review!
I will replace the irrelevant paragraphs with:
> Documentation and examples may be found at https://param.holoviz.org.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-param FEDORA-2021-5998cdb069 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-5998cdb069 FEDORA-2021-852f7cc378 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-852f7cc378 FEDORA-2021-852f7cc378 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-852f7cc378 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-852f7cc378 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-5998cdb069 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-5998cdb069 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-5998cdb069 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-5998cdb069 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2021-852f7cc378 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. |