Bug 2018847 - Review Request: python-param - Make your Python code clearer and more reliable by declaring Parameters
Summary: Review Request: python-param - Make your Python code clearer and more reliabl...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2019157 2022153
TreeView+ depends on / blocked
 
Reported: 2021-11-01 00:07 UTC by Ben Beasley
Modified: 2021-12-02 02:02 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-12-02 01:14:53 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Ben Beasley 2021-11-01 00:07:41 UTC
Spec URL: https://music.fedorapeople.org/python-param.spec
SRPM URL: python-param-1.12.0-1.fc34.src.rpm

Description:

Param is a library providing Parameters: Python attributes extended to have
features such as type and range checking, dynamically generated values,
documentation strings, default values, etc., each of which is inherited from
parent classes if not specified in a subclass.

Param contains only two required Python files, with no external dependencies,
and is provided freely for both non-commercial and commercial use under a BSD
license, so that it can easily be included as part of other projects.

Please see param’s website (https://param.holoviz.org/) for official releases,
installation instructions, documentation, and examples.

Fedora Account System Username: music

Reverse dependencies: https://www.wheelodex.org/projects/param/rdepends/

Koji scratch builds:

F36: https://koji.fedoraproject.org/koji/taskinfo?taskID=78129292
F35: https://koji.fedoraproject.org/koji/taskinfo?taskID=78129394
F34: https://koji.fedoraproject.org/koji/taskinfo?taskID=78129668

Comment 1 Ben Beasley 2021-11-01 00:09:16 UTC
Fixed SRPM URL: https://music.fedorapeople.org/python-param-1.12.0-1.fc34.src.rpm

Comment 2 Zbigniew Jędrzejewski-Szmek 2021-11-21 20:19:48 UTC
(In reply to Ben Beasley from comment #0)
> Param contains only two required Python files, with no external dependencies,
> and is provided freely for both non-commercial and commercial use under a BSD
> license, so that it can easily be included as part of other projects.
> 
> Please see param’s website (https://param.holoviz.org/) for official
> releases,
> installation instructions, documentation, and examples.

Those two paragraphs are not relevant to Fedora users, who don't need to care about
packaging or upstream installation instructions. Maybe just leave the link to the
upstream website?

+ package name is OK
+ license is acceptable (BSD)
+ license is specified correctly
+ latest version (there's a new alpha release, but we don't need that)
+ standard template with pyproject macros is used
+ BR/R/P look OK
+ builds and installs OK

rpmlint:
python3-param.noarch: W: no-documentation
python3-param.noarch: W: hidden-file-or-dir /usr/lib/python3.10/site-packages/param/.version
python-param.src: W: strange-permission python-param.spec 600
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

All OK, I guess.


Package is APPROVED.

Comment 3 Ben Beasley 2021-11-21 20:27:54 UTC
Thanks for the review!

I will replace the irrelevant paragraphs with:

> Documentation and examples may be found at https://param.holoviz.org.

Comment 4 Gwyn Ciesla 2021-11-22 15:48:27 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-param

Comment 5 Fedora Update System 2021-11-23 13:08:13 UTC
FEDORA-2021-5998cdb069 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-5998cdb069

Comment 6 Fedora Update System 2021-11-23 13:11:31 UTC
FEDORA-2021-852f7cc378 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-852f7cc378

Comment 7 Fedora Update System 2021-11-24 01:56:31 UTC
FEDORA-2021-852f7cc378 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-852f7cc378 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-852f7cc378

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-11-24 01:57:18 UTC
FEDORA-2021-5998cdb069 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-5998cdb069 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-5998cdb069

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-12-02 01:14:53 UTC
FEDORA-2021-5998cdb069 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2021-12-02 02:02:55 UTC
FEDORA-2021-852f7cc378 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.