Bug 2021029

Summary:	Review Request: phonesim - Phone Simulator for modem testing
Product:	[Fedora] Fedora	Reporter:	Onuralp SEZER <thunderbirdtr>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	fedora, justin.zobel, package-review, pemensik
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-02-19 00:45:21 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449

Description Onuralp SEZER 2021-11-08 06:34:58 UTC

Spec URL: https://pagure.io/phonesim/raw/main/f/phonesim.spec
SRPM URL: https://pagure.io/phonesim/raw/main/f/phonesim-1.21-1.fc35.src.rpm
Description: 	
phonesim is a soft modem that eliminates the need to have an actual AT
modem connected to the system for testing and developing Ofono.

Fedora Account System Username: thunderbirdtr

Pagure URL : https://pagure.io/phonesim

Comment 1 Artur Frenszek-Iwicki 2021-11-09 10:40:40 UTC

> %configure
> %{__make} %{?_smp_mflags}
1. Using macro forms of system executables (%{__make}, %{__rm}, etc.) is discouraged.
   https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros
2. "%make_build" is preferred for building.

> %files
> %{_datarootdir}/%{name}/default.xml
This will make the package own the "/usr/share/phonesim/default.xml" file, but not the "/usr/share/phonesim" directory.
https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/

Also, the license file is not included in the package. Add "%license COPYING" under %files.

Comment 2 Justin Zobel 2022-02-06 02:34:13 UTC

I believe this can now be abandoned as it is part of ofono and no longer used by the Plasma Mobile stack.

Comment 3 Petr Menšík 2023-01-19 00:53:35 UTC

There were recently released version 2.0 [1]. This package might need version update or closing the review bug. Please close this review is you do not want to include this package anymore. Is it still useful to be included?

[1] https://git.kernel.org/pub/scm/network/ofono/phonesim.git/tag/?h=2.0

Comment 4 Package Review 2023-02-19 00:45:21 UTC

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.