Bug 2021938
| Summary: | python-unicodecsv fails to build with Python 3.11: AssertionError: [['ab\x00c']] != None | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomáš Hrnčiar <thrnciar> |
| Component: | python-unicodecsv | Assignee: | Joel Capitao <jcapitao> |
| Status: | CLOSED WORKSFORME | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 36 | CC: | apevec, hugovk+redhatbugzilla, jcapitao, jpena, mhroncok, thrnciar |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-08-30 09:18:31 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2016048, 2045102, 2045109, 2117176, 2119846 | ||
The upstream project last had a release and commit in 2015: https://pypi.org/project/unicodecsv/ https://github.com/jdunck/python-unicodecsv And appears unmaintained: https://github.com/jdunck/python-unicodecsv/issues/92 Upstream tests pass (via tox) for 3.5-3.9, but fail for 2.7, 3.10 and 3.11. But it's a backport: "The unicodecsv is a drop-in replacement for Python 2.7's csv module which supports unicode strings without a hassle. Supported versions are python 2.6, 2.7, 3.3, 3.4, 3.5, and pypy 2.4.0." So it's perhaps better to replace the use of the backport in other projects. $ repoquery -q --repo=rawhide{,-source} --whatrequires python3-unicodecsv
python-rows-0:0.4.1-12.fc35.src
python3-registry-0:1.4-4.fc35.noarch
python3-rows-0:0.4.1-12.fc35.noarch
https://src.fedoraproject.org/rpms/python-registry
https://src.fedoraproject.org/rpms/python-rows
python-rows runs no tests in %check so the BR can be removed but the runtime dep is declared and it would need to be checked in more detail. python-registry only has a manually specified runtime dependency in the spec and it runs tests in %check happily without it, so I assume it is redundant. This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle. Changing version to 36. *** Bug 2099136 has been marked as a duplicate of this bug. *** Hello, This is the first reminder (step 3 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs). If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem. I proposed PRs upstream to switch from unicodecsv to standard csv library which now supports unicode. https://github.com/williballenthin/python-registry/pull/105 https://github.com/turicas/rows/pull/367 The distgit patches below: https://src.fedoraproject.org/rpms/python-registry/pull-request/1 https://src.fedoraproject.org/rpms/python-rows/pull-request/2 I will retire python-unicodecsv once those patches merged Hello Alan, As you're main admin, could you fedpkg retire "Standard CSV library now supports unicode" please ? I can retire the pacakge as provenpackager. Is that OK? It's ok for me Retired in dist-git on f37 and rawhide branches. Waiting for the compose to get it blocked. Hello, Please note that this comment was generated automatically. If you feel that this output has mistakes, please contact me via email (mhroncok). All subpackages of a package against which this bug was filled are now installable or removed from Fedora 38. Thanks for taking care of it! Hello, Please note that this comment was generated automatically. If you feel that this output has mistakes, please contact me via email (mhroncok). All subpackages of a package against which this bug was filled are now installable or removed from Fedora 37. Thanks for taking care of it! Thank you Miro for the actions |
python-unicodecsv fails to build with Python 3.11.0a2. + python3 -m unittest ...............................................................F................ ====================================================================== FAIL: test_read_oddinputs (unicodecsv.test.Test_Csv) ---------------------------------------------------------------------- Traceback (most recent call last): File "/builddir/build/BUILD/unicodecsv-0.14.1/unicodecsv/test.py", line 254, in test_read_oddinputs self.assertRaises(csv.Error, self._read_test, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AssertionError: [['ab\x00c']] != None ---------------------------------------------------------------------- Ran 80 tests in 0.025s FAILED (failures=1) For the build logs, see: https://copr-be.cloud.fedoraproject.org/results/@python/python3.11/fedora-rawhide-x86_64/02940843-python-unicodecsv/ For all our attempts to build python-unicodecsv with Python 3.11, see: https://copr.fedorainfracloud.org/coprs/g/python/python3.11/package/python-unicodecsv/ Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.11: https://copr.fedorainfracloud.org/coprs/g/python/python3.11/ Let us know here if you have any questions. Python 3.11 is planned to be included in Fedora 37. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.11. A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon. We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.