Bug 2021938 - python-unicodecsv fails to build with Python 3.11: AssertionError: [['ab\x00c']] != None
Summary: python-unicodecsv fails to build with Python 3.11: AssertionError: [['ab\x00c...
Keywords:
Status: CLOSED WORKSFORME
Alias: None
Product: Fedora
Classification: Fedora
Component: python-unicodecsv
Version: 36
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Joel Capitao
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2099136 (view as bug list)
Depends On:
Blocks: PYTHON3.11 F37FTBFS F37FailsToInstall F38FTBFS 2119846
TreeView+ depends on / blocked
 
Reported: 2021-11-10 13:09 UTC by Tomáš Hrnčiar
Modified: 2022-08-31 09:30 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-08-30 09:18:31 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tomáš Hrnčiar 2021-11-10 13:09:52 UTC
python-unicodecsv fails to build with Python 3.11.0a2.

+ python3 -m unittest
...............................................................F................
======================================================================
FAIL: test_read_oddinputs (unicodecsv.test.Test_Csv)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/unicodecsv-0.14.1/unicodecsv/test.py", line 254, in test_read_oddinputs
    self.assertRaises(csv.Error, self._read_test,
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: [['ab\x00c']] != None

----------------------------------------------------------------------
Ran 80 tests in 0.025s

FAILED (failures=1)

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.11/fedora-rawhide-x86_64/02940843-python-unicodecsv/

For all our attempts to build python-unicodecsv with Python 3.11, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.11/package/python-unicodecsv/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.11:
https://copr.fedorainfracloud.org/coprs/g/python/python3.11/

Let us know here if you have any questions.

Python 3.11 is planned to be included in Fedora 37. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.11.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Hugo van Kemenade 2022-01-07 10:16:18 UTC
The upstream project last had a release and commit in 2015:

https://pypi.org/project/unicodecsv/
https://github.com/jdunck/python-unicodecsv

And appears unmaintained:

https://github.com/jdunck/python-unicodecsv/issues/92

Upstream tests pass (via tox) for 3.5-3.9, but fail for 2.7, 3.10 and 3.11.

But it's a backport:

"The unicodecsv is a drop-in replacement for Python 2.7's csv module which supports unicode strings without a hassle. Supported versions are python 2.6, 2.7, 3.3, 3.4, 3.5, and pypy 2.4.0."

So it's perhaps better to replace the use of the backport in other projects.

Comment 2 Miro Hrončok 2022-01-07 11:26:52 UTC
$ repoquery -q --repo=rawhide{,-source} --whatrequires python3-unicodecsv
python-rows-0:0.4.1-12.fc35.src
python3-registry-0:1.4-4.fc35.noarch
python3-rows-0:0.4.1-12.fc35.noarch


https://src.fedoraproject.org/rpms/python-registry
https://src.fedoraproject.org/rpms/python-rows

Comment 3 Miro Hrončok 2022-01-07 11:29:53 UTC
python-rows runs no tests in %check so the BR can be removed but the runtime dep is declared and it would need to be checked in more detail.


python-registry only has a manually specified runtime dependency in the spec and it runs tests in %check happily without it, so I assume it is redundant.

Comment 4 Ben Cotton 2022-02-08 21:16:16 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle.
Changing version to 36.

Comment 5 Miro Hrončok 2022-06-20 10:20:25 UTC
*** Bug 2099136 has been marked as a duplicate of this bug. ***

Comment 6 Miro Hrončok 2022-06-27 14:52:32 UTC
Hello,

This is the first reminder (step 3 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs).

If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem.

Comment 7 Joel Capitao 2022-06-30 14:41:41 UTC
I proposed PRs upstream to switch from unicodecsv to standard csv library which
now supports unicode.

https://github.com/williballenthin/python-registry/pull/105
https://github.com/turicas/rows/pull/367

Comment 9 Joel Capitao 2022-08-04 09:07:33 UTC
I will retire python-unicodecsv once those patches merged

Comment 10 Joel Capitao 2022-08-22 17:58:29 UTC
Hello Alan,
As you're main admin, could you fedpkg retire "Standard CSV library now supports unicode" please ?

Comment 11 Miro Hrončok 2022-08-25 09:38:46 UTC
I can retire the pacakge as provenpackager. Is that OK?

Comment 12 Joel Capitao 2022-08-26 13:38:10 UTC
It's ok for me

Comment 13 Miro Hrončok 2022-08-29 10:06:51 UTC
Retired in dist-git on f37 and rawhide branches. Waiting for the compose to get it blocked.

Comment 14 Miro Hrončok 2022-08-30 09:17:01 UTC
Hello,

Please note that this comment was generated automatically. If you feel that this output has mistakes, please contact me via email (mhroncok).

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 38.

Thanks for taking care of it!

Comment 15 Miro Hrončok 2022-08-30 09:18:31 UTC
Hello,

Please note that this comment was generated automatically. If you feel that this output has mistakes, please contact me via email (mhroncok).

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 37.

Thanks for taking care of it!

Comment 16 Joel Capitao 2022-08-31 09:30:01 UTC
Thank you Miro for the actions


Note You need to log in before you can comment on or make changes to this bug.