Bug 2022208
| Summary: | Review Request: rust-unic-langid-impl - API for managing Unicode Language Identifiers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Link Dupont <link> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-12-11 01:30:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2022206, 2022211 | ||
|
Description
Link Dupont
2021-11-11 04:27:12 UTC
Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-unic-langid-impl FEDORA-2021-01f7520709 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709 FEDORA-2021-01f7520709 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-01f7520709 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. Sorry for the noise, but for completeness, I accidentally commented with some issues in this package on the wrong review request: https://bugzilla.redhat.com/show_bug.cgi?id=2022205#c5 TL;DR: This package *does* contain binaries (and it shouldn't), overriding double-underscored-macros like __cargo_skip_build is a bad idea (those are not meant to be set in .spec files), and the macro was removed with rust2rpm 20. Please use an alternative method of disabling those binaries (as outlined in the linked comment). FEDORA-2021-01f7520709 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709 FEDORA-2021-01f7520709 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-01f7520709 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-01f7520709 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. |