Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02872620-rust-unic-langid-macros/rust-unic-langid-macros.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02872620-rust-unic-langid-macros/rust-unic-langid-macros-0.9.0-1.fc36.src.rpm Description: API for managing Unicode Language Identifiers Fedora Account System Username: linkdupont Fedora Review: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02872620-rust-unic-langid-macros/fedora-review
Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-unic-langid-macros
FEDORA-2021-01f7520709 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709
FEDORA-2021-01f7520709 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-01f7520709 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
> - only sources installed This is not true. The package installs two binaries (even though it was "turned off" by setting a dunder-macro). Just overriding __cargo_skip_build is the wrong thing to do here (as is overriding double-underscored-macros, in general), because that also makes the package noarch, where it shouldn't be, so tests only run on one architecture at a time, etc. Additionally, this unconventional use of "__cargo_skip_build 1" is now broken, because that macro was under no circumstances set to 1 since Fedora 31 or so (it was only ever set to 1 in module builds, and it's been a long while since those were a thing for Rust). Since it looks like those binaries are only used for upstream development, I suggest to drop them from the .spec file entirely to prevent future issues like this. You can look at https://src.fedoraproject.org/rpms/rust-protobuf-codegen-pure/tree/rawhide for an example how to do that relatively easily (rust2rpm will not even generate the subpackages related to binaries if you do it like this). Another way to do this (that's not as nice) is to set the __cargo_is_bin() macro to 0 and drop the generated binary subpackage manually, like in cargo: https://src.fedoraproject.org/rpms/rust-cargo/blob/rawhide/f/rust-cargo.spec But the first solution (small patch to disable building the binaries) is a cleaner solution, as that also automatically adapts the generated .spec file.
Oh, sorry, I commented on the wrong bug, this should've been on the rust-unic-langid-impl review request, instead. PS: You can see that the package now fails to build because it relies on the "__cargo_skip_build" implementation detail, which was removed with rust2rpm 20: https://koschei.fedoraproject.org/package/rust-unic-langid-impl?collection=f36
FEDORA-2021-01f7520709 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.