Bug 2022623

Summary: Don't write mac-address-blacklist= in keyfiles
Product: Red Hat Enterprise Linux 9 Reporter: Till Maas <till>
Component: NetworkManagerAssignee: Ana Cabral <acabral>
Status: CLOSED ERRATA QA Contact: David Jaša <djasa>
Severity: unspecified Docs Contact:
Priority: low    
Version: 9.0CC: bgalvani, djasa, fge, lrintel, rkhan, sukulkar, thaller, till, vbenes
Target Milestone: rcKeywords: Triaged
Target Release: 9.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: NetworkManager-1.36.0-0.10.el9 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-05-17 15:48:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Till Maas 2021-11-12 08:21:01 UTC
Description of problem:
Keyfiles contain

[ethernet]

mac-address-blacklist=

when no mac address denylist is configured. 

User story:
In order to not offend my system administrators, as as business owner, I can configure Linux networking without the system using inappropriate language.

Acceptance criteria:

Given a Linux system with NM, when I configure a profile without any denylist of mac addresses using keyfiles then "mac-address-blacklist" will not appear in the keyfile.

Comment 1 Thomas Haller 2022-02-02 13:29:50 UTC
in general, properties that are at their default (i.e. "empty"), should not be written to keyfile.

see for example, "connection.permissions" and "ipv[46].dns-search"

Comment 2 Till Maas 2022-02-02 20:59:39 UTC
(In reply to Thomas Haller from comment #1)
> in general, properties that are at their default (i.e. "empty"), should not
> be written to keyfile.
> 
> see for example, "connection.permissions" and "ipv[46].dns-search"

This would be nice, however this is out of scope for this BZ. If the other properties are adjusted as a side-effect, that's fine. At the same time I would like to see that this task stays focused to fix the requirements and respect "Do the simplest thing that could possibly work", see https://ronjeffries.com/xprog/articles/practices/pracsimplest/#:~:text=The%20most%20important%20rule%20in,ability%20to%20make%20rapid%20progress.

Comment 6 David Jaša 2022-02-28 09:49:54 UTC
(In reply to Till Maas from comment #0)
> User story:
> In order to not offend my system administrators, as as business owner, I can
> configure Linux networking without the system using inappropriate language.
> 
> Acceptance criteria:
> 
> Given a Linux system with NM, when I configure a profile without any
> denylist of mac addresses using keyfiles then "mac-address-blacklist" will
> not appear in the keyfile.

Let's have an existing system with these empty options in keyfiles. Are they supposed to vanish on upgrade of NM? They do vanish on connection modification but not when NM gets upgraded to version that contains current fix.

Comment 7 Till Maas 2022-02-28 15:54:46 UTC
(In reply to David Jaša from comment #6)
> (In reply to Till Maas from comment #0)
> > User story:
> > In order to not offend my system administrators, as as business owner, I can
> > configure Linux networking without the system using inappropriate language.
> > 
> > Acceptance criteria:
> > 
> > Given a Linux system with NM, when I configure a profile without any
> > denylist of mac addresses using keyfiles then "mac-address-blacklist" will
> > not appear in the keyfile.
> 
> Let's have an existing system with these empty options in keyfiles. Are they
> supposed to vanish on upgrade of NM? They do vanish on connection
> modification but not when NM gets upgraded to version that contains current
> fix.

Thank you, this is ok.

Comment 8 David Jaša 2022-02-28 16:11:00 UTC
ok in 1.36.0-1 as per comment 6 and comment 7.

Comment 10 errata-xmlrpc 2022-05-17 15:48:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: NetworkManager), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:3915