RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2022623 - Don't write mac-address-blacklist= in keyfiles
Summary: Don't write mac-address-blacklist= in keyfiles
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: NetworkManager
Version: 9.0
Hardware: Unspecified
OS: Unspecified
low
unspecified
Target Milestone: rc
: 9.1
Assignee: Ana Cabral
QA Contact: David Jaša
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-11-12 08:21 UTC by Till Maas
Modified: 2022-05-17 16:07 UTC (History)
9 users (show)

Fixed In Version: NetworkManager-1.36.0-0.10.el9
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-17 15:48:15 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-102584 0 None None None 2021-11-12 08:22:10 UTC
Red Hat Product Errata RHBA-2022:3915 0 None None None 2022-05-17 15:48:28 UTC
freedesktop.org Gitlab NetworkManager NetworkManager-ci merge_requests 975 0 None opened ethernet - don't save empty mac-address-blacklist= option to keyfiles 2022-02-28 18:41:12 UTC
freedesktop.org Gitlab NetworkManager NetworkManager merge_requests 1088 0 None merged keyfile/conscious language: do not write empty field mac-address-blacklist in keyfiles 2022-02-28 18:41:09 UTC

Description Till Maas 2021-11-12 08:21:01 UTC 
Description of problem:
Keyfiles contain

[ethernet]

mac-address-blacklist=

when no mac address denylist is configured. 

User story:
In order to not offend my system administrators, as as business owner, I can configure Linux networking without the system using inappropriate language.

Acceptance criteria:

Given a Linux system with NM, when I configure a profile without any denylist of mac addresses using keyfiles then "mac-address-blacklist" will not appear in the keyfile.
Comment 1 Thomas Haller 2022-02-02 13:29:50 UTC 
in general, properties that are at their default (i.e. "empty"), should not be written to keyfile.

see for example, "connection.permissions" and "ipv[46].dns-search"
Comment 2 Till Maas 2022-02-02 20:59:39 UTC 
(In reply to Thomas Haller from comment #1)
> in general, properties that are at their default (i.e. "empty"), should not
> be written to keyfile.
> 
> see for example, "connection.permissions" and "ipv[46].dns-search"

This would be nice, however this is out of scope for this BZ. If the other properties are adjusted as a side-effect, that's fine. At the same time I would like to see that this task stays focused to fix the requirements and respect "Do the simplest thing that could possibly work", see https://ronjeffries.com/xprog/articles/practices/pracsimplest/#:~:text=The%20most%20important%20rule%20in,ability%20to%20make%20rapid%20progress.
Comment 6 David Jaša 2022-02-28 09:49:54 UTC 
(In reply to Till Maas from comment #0)
> User story:
> In order to not offend my system administrators, as as business owner, I can
> configure Linux networking without the system using inappropriate language.
> 
> Acceptance criteria:
> 
> Given a Linux system with NM, when I configure a profile without any
> denylist of mac addresses using keyfiles then "mac-address-blacklist" will
> not appear in the keyfile.

Let's have an existing system with these empty options in keyfiles. Are they supposed to vanish on upgrade of NM? They do vanish on connection modification but not when NM gets upgraded to version that contains current fix.
Comment 7 Till Maas 2022-02-28 15:54:46 UTC 
(In reply to David Jaša from comment #6)
> (In reply to Till Maas from comment #0)
> > User story:
> > In order to not offend my system administrators, as as business owner, I can
> > configure Linux networking without the system using inappropriate language.
> > 
> > Acceptance criteria:
> > 
> > Given a Linux system with NM, when I configure a profile without any
> > denylist of mac addresses using keyfiles then "mac-address-blacklist" will
> > not appear in the keyfile.
> 
> Let's have an existing system with these empty options in keyfiles. Are they
> supposed to vanish on upgrade of NM? They do vanish on connection
> modification but not when NM gets upgraded to version that contains current
> fix.

Thank you, this is ok.
Comment 8 David Jaša 2022-02-28 16:11:00 UTC 
ok in 1.36.0-1 as per comment 6 and comment 7.
Comment 10 errata-xmlrpc 2022-05-17 15:48:15 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: NetworkManager), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:3915
Note You need to log in before you can comment on or make changes to this bug.