Bug 202853 (wfut)

Summary: Review Request: wfut - WorldForge media updater tool
Product: [Fedora] Fedora Reporter: Wart <wart>
Component: Package ReviewAssignee: Christopher Stone <chris.stone>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: che666
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-09-04 04:16:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779, 198839    

Description Wart 2006-08-16 19:40:22 UTC
Spec URL: http://www.kobold.org/~wart/fedora/wfut.spec
SRPM URL: http://www.kobold.org/~wart/fedora/wfut-1.0-1.src.rpm
Description: 
Media updater tool for WorldForge applications

Comment 1 Wart 2006-08-16 22:11:28 UTC
This one loses the "BR: autoconf automake" as they aren't needed anymore:

http://www.kobold.org/~wart/fedora/wfut.spec
http://www.kobold.org/~wart/fedora/wfut-1.0-2.src.rpm

Comment 2 Wart 2006-08-17 20:51:02 UTC
Added a .desktop file and icon, and removed the unnecessary shell script in
/usr/bin:

http://www.kobold.org/~wart/fedora/wfut.spec
http://www.kobold.org/~wart/fedora/wfut-1.0-3.src.rpm

Comment 3 Christopher Stone 2006-09-04 01:27:38 UTC
- rpmlint output clean
- package named according to package naming guildelines
- spec file name matches %{name}
- package meets packaging guidelines
- licensed with open source compatible license
- license matches actual license
- license file included in %doc
- spec file written in American english
- spec file is legible
- sources match upstream
23d40558c121d5c52917846a36d48b80  WFUT-1.0-SNAPSHOT-src.tar.gz
- compiles and builds on fc5 x86_64
- all build dependencies listed in build requires
- package does not use locales
- package does not contain shared libraries
- package is not relocatable
- package owns all directories it creates
- no duplicates in %files
- permissions on files set properly
- contains proper %clean section
- macro usage is consistent
- package contains permissible content
- no large documentation
- %doc files do not affect runtime
- no header files or static libraries
- no pkgconfig files
- no library files
- no devel package
- no .la files
- package is a GUI application and contains proper desktop files
- package does not own files or directories owned by other packages


I can't find anything wrong with this spec file.  Approved.

Comment 4 Wart 2006-09-04 04:16:25 UTC
Imported and built.  Thanks!