Bug 2030050
| Summary: | Review Request: tinysa-saver - Tool for reading, displaying and saving data from the tinySA | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jaroslav Škarvada <jskarvad> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | aekoroglu, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jaroslav Škarvada
2021-12-07 20:55:35 UTC
I changed python macro, SPDX license and did some makeup :)
--- a/tinysa-saver.spec 2021-12-07 22:34:48.000000000 +0200
+++ b/tinysa-saver.spec 2022-11-08 10:28:15.981892142 +0200
@@ -5,27 +5,25 @@
Version: 0.11
Release: 1%{?dist}
Summary: Tool for reading, displaying and saving data from the TinySA
-License: GPLv3
-URL: https://github.com/erikkaashoek/tinySA-saver
+License: GPL-3.0-or-later
+URL: https://github.com/erikkaashoek/tinySA-saver
Source0: %{URL}/archive/v%{version}/%{name}-%{version}.tar.gz
# Reported upstream: https://github.com/mihtjel/nanovna-saver/issues/163
Source1: tinysa-saver.desktop
+
+# OS/distro specific
+Patch0: tinysa-saver-0.11-fedora-icon.patch
+# original patch
+# https://github.com/mihtjel/nanovna-saver/pull/162
+Patch1: tinysa-saver-0.11-test-fix.patch
+
BuildArch: noarch
-BuildRequires: python3-setuptools
+
BuildRequires: python3-devel
-BuildRequires: python3-pyserial
-BuildRequires: python3-numpy
-BuildRequires: python3-scipy
-BuildRequires: python3-qt5
-BuildRequires: sed
+BuildRequires: python3-pytest
BuildRequires: desktop-file-utils
Requires: hicolor-icon-theme
-# OS/distro specific
-Patch0: tinysa-saver-0.11-fedora-icon.patch
-# original patch
-# https://github.com/mihtjel/nanovna-saver/pull/162
-Patch1: tinysa-saver-0.11-test-fix.patch
%description
A multiplatform tool to save scans from the TinySA, sweep frequency
@@ -33,17 +31,20 @@
display and analyze the resulting data.
%prep
-%setup -q
-%autopatch -p1
+%autosetup -p1 -n %{name}-%{version}
# Drop shebang of non-executable
sed -i '1 d' TinySASaver/__main__.py
+%generate_buildrequires
+%pyproject_buildrequires
+
%build
-%py3_build
+%pyproject_wheel
%install
-%py3_install
+%pyproject_install
+%pyproject_save_files TinySASaver
# drop the tests, we do not need them in production, do not use rm -rf
pushd %{buildroot}%{python3_sitelib}
@@ -63,14 +64,11 @@
%{SOURCE1}
%check
-%{python3} setup.py test
+%pytest -v
-%files
-%license LICENSE
+%files -n %{name} -f %{pyproject_files}
%doc README.md
%{_bindir}/TinySASaver
-%{python3_sitelib}/TinySASaver
-%{python3_sitelib}/TinySASaver-%{pyversion}-py*.egg-info
%{_datadir}/icons/hicolor/48x48/apps/%{name}.png
%{_datadir}/applications/%{name}.desktop
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted. This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket. |