Bug 2030050 - Review Request: tinysa-saver - Tool for reading, displaying and saving data from the tinySA
Summary: Review Request: tinysa-saver - Tool for reading, displaying and saving data f...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-12-07 20:55 UTC by Jaroslav Škarvada
Modified: 2023-12-12 00:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jaroslav Škarvada 2021-12-07 20:55:35 UTC
Spec URL: https://jskarvad.fedorapeople.org/tinysa/tinysa-saver.spec
SRPM URL: https://jskarvad.fedorapeople.org/tinysa/tinysa-saver-0.11-1.fc36.src.rpm
Description: A multiplatform tool to save scans from the TinySA, sweep frequency spans in segments to gain more than 290 data points, and generally display and analyze the resulting data.
Fedora Account System Username: jskarvad

It's fork from the nanovna-saver, but TinySA is different hardware than the NanoVNA - i.e. Spectrum Analyzer vs Vector Network Analyzer. It's unlikely that nanovna-saver upstream would ever support spectrum analyzers. If they add the support in the future I will drop this package (I am currently maintaining nanovna-saver in the Fedora). The fork is not intended to control the original NanoVNA, just the TinySA.

Comment 1 Ali Erdinc Koroglu 2022-11-08 09:03:19 UTC
I changed python macro, SPDX license and did some makeup :)

--- a/tinysa-saver.spec 2021-12-07 22:34:48.000000000 +0200
+++ b/tinysa-saver.spec 2022-11-08 10:28:15.981892142 +0200
@@ -5,27 +5,25 @@
 Version:   0.11
 Release:   1%{?dist}
 Summary:   Tool for reading, displaying and saving data from the TinySA
-License:   GPLv3
-URL:       https://github.com/erikkaashoek/tinySA-saver

+License:   GPL-3.0-or-later
+URL:       https://github.com/erikkaashoek/tinySA-saver
 Source0:   %{URL}/archive/v%{version}/%{name}-%{version}.tar.gz
 # Reported upstream: https://github.com/mihtjel/nanovna-saver/issues/163
 Source1:   tinysa-saver.desktop
+
+# OS/distro specific
+Patch0:         tinysa-saver-0.11-fedora-icon.patch
+# original patch
+# https://github.com/mihtjel/nanovna-saver/pull/162
+Patch1:         tinysa-saver-0.11-test-fix.patch
+
 BuildArch: noarch
-BuildRequires: python3-setuptools
+
 BuildRequires: python3-devel
-BuildRequires: python3-pyserial
-BuildRequires: python3-numpy
-BuildRequires: python3-scipy
-BuildRequires: python3-qt5
-BuildRequires: sed
+BuildRequires: python3-pytest
 BuildRequires: desktop-file-utils
 Requires:  hicolor-icon-theme
-# OS/distro specific
-Patch0:        tinysa-saver-0.11-fedora-icon.patch
-# original patch
-# https://github.com/mihtjel/nanovna-saver/pull/162
-Patch1:        tinysa-saver-0.11-test-fix.patch

 %description
 A multiplatform tool to save scans from the TinySA, sweep frequency
@@ -33,17 +31,20 @@
 display and analyze the resulting data.

 %prep
-%setup -q
-%autopatch -p1
+%autosetup -p1 -n %{name}-%{version}

 # Drop shebang of non-executable
 sed -i '1 d' TinySASaver/__main__.py

+%generate_buildrequires
+%pyproject_buildrequires
+
 %build
-%py3_build
+%pyproject_wheel

 %install
-%py3_install
+%pyproject_install
+%pyproject_save_files TinySASaver

 # drop the tests, we do not need them in production, do not use rm -rf
 pushd %{buildroot}%{python3_sitelib}
@@ -63,14 +64,11 @@
   %{SOURCE1}

 %check
-%{python3} setup.py test
+%pytest -v

-%files
-%license LICENSE
+%files -n %{name} -f %{pyproject_files}
 %doc README.md
 %{_bindir}/TinySASaver
-%{python3_sitelib}/TinySASaver
-%{python3_sitelib}/TinySASaver-%{pyversion}-py*.egg-info
 %{_datadir}/icons/hicolor/48x48/apps/%{name}.png
 %{_datadir}/applications/%{name}.desktop

Comment 2 Package Review 2023-11-11 00:45:27 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 3 Package Review 2023-12-12 00:45:25 UTC
This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.


Note You need to log in before you can comment on or make changes to this bug.