Bug 2031035

Summary: Add rhel-8.6.0 machine types for RHEL 8.6 [x86]
Product: Red Hat Enterprise Linux 8 Reporter: Cornelia Huck <cohuck>
Component: qemu-kvmAssignee: Dr. David Alan Gilbert <dgilbert>
qemu-kvm sub component: Machine Types QA Contact: jingzhao <jinzhao>
Status: CLOSED ERRATA Docs Contact:
Severity: unspecified    
Priority: unspecified CC: berrange, coli, dgilbert, jinzhao, virt-maint, ymankad
Version: 8.6Keywords: Triaged
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: qemu-kvm-6.2.0-5.module+el8.6.0+14006+80bd780c Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-05-10 13:24:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2031032    

Description Cornelia Huck 2021-12-10 11:16:42 UTC
The rhel-8.6.0 machine types need to be added for x86.

Comment 1 John Ferlan 2021-12-10 20:58:37 UTC
How does this differ from existing bug 2022604?  Can we close this as a duplicate of that - being sure to update bug 2031032 with the (older) reference...

Comment 2 Cornelia Huck 2021-12-13 08:52:25 UTC
(In reply to John Ferlan from comment #1)
> How does this differ from existing bug 2022604?  Can we close this as a
> duplicate of that - being sure to update bug 2031032 with the (older)
> reference...

Same as for the other bug(s) -- the existing bug deals with compat values, this one with the actual machine types.

Comment 3 Daniel Berrangé 2021-12-16 12:09:59 UTC
Note historically the RHEL x86 machine types have overridden some of the SMBIOS defaults:

    pcmc->smbios_stream_product = "RHEL-AV";
    pcmc->smbios_stream_version = "8.5.0";

In 8.6,  RHEL-AV was folded back into RHEL. So there's a question of whether we should still refer to the 'smbios_stream_product' as "RHEL-AV" or revert to "RHEL"

IIUC, this info is used as a hook for things like the Windows drivers, so the safe option might be to leave it as 'RHEL-AV' for the remainder of RHEL-8.x series, and only change to 'RHEL' in the RHEL-9.x series machine types.

Comment 4 Dr. David Alan Gilbert 2021-12-16 19:46:47 UTC
(In reply to Daniel Berrangé from comment #3)
> Note historically the RHEL x86 machine types have overridden some of the
> SMBIOS defaults:
> 
>     pcmc->smbios_stream_product = "RHEL-AV";
>     pcmc->smbios_stream_version = "8.5.0";
> 
> In 8.6,  RHEL-AV was folded back into RHEL. So there's a question of whether
> we should still refer to the 'smbios_stream_product' as "RHEL-AV" or revert
> to "RHEL"
> 
> IIUC, this info is used as a hook for things like the Windows drivers, so
> the safe option might be to leave it as 'RHEL-AV' for the remainder of
> RHEL-8.x series,

That seems safest; I'd rather not change anything in drivers if not essential.

> and only change to 'RHEL' in the RHEL-9.x series machine types.

Do we even have to do that?  If we just left it witht he -AV on the end it wouldn't hurt anyone
and would give a chance for the same image to work on 8 and 9

Comment 5 Daniel Berrangé 2021-12-17 13:18:59 UTC
(In reply to Dr. David Alan Gilbert from comment #4)
> (In reply to Daniel Berrangé from comment #3)
> > IIUC, this info is used as a hook for things like the Windows drivers, so
> > the safe option might be to leave it as 'RHEL-AV' for the remainder of
> > RHEL-8.x series,
> 
> That seems safest; I'd rather not change anything in drivers if not
> essential.
> 
> > and only change to 'RHEL' in the RHEL-9.x series machine types.
> 
> Do we even have to do that?  If we just left it witht he -AV on the end it
> wouldn't hurt anyone
> and would give a chance for the same image to work on 8 and 9

We don't have to change it, I just felt it looks wierd to be refering to a product that no longer exists. even in RHEL-8 it was a little weird because the same machine types were used by RHEL & RHEL-AV.

I put a similar comment on the corresponding rhel9 bug 1945666 so we can consider it separately.

Comment 14 Yanan Fu 2022-01-27 02:29:02 UTC
QE bot(pre verify): Set 'Verified:Tested,SanityOnly' as gating/tier1 test pass.

Comment 17 errata-xmlrpc 2022-05-10 13:24:21 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: virt:rhel and virt-devel:rhel security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:1759