Bug 2031162

Summary:	Review Request: rust-base64ct - Pure Rust, constant-time implementation of Base64 (RFC 4648)
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Trystram <jbtrystram>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	jbtrystram, package-review
Target Milestone:	---	Flags:	jbtrystram: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-12-13 17:15:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Fabio Valentini 2021-12-10 16:27:38 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-base64ct.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-base64ct-1.3.0-1.fc35.src.rpm

Description:
Pure Rust implementation of Base64 (RFC 4648) which avoids any usages of data-
dependent branches/LUTs and thereby provides portable "best effort" constant-
time operation and embedded-friendly no_std support.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2021-12-10 16:27:41 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=79794322

Comment 2 Trystram 2021-12-13 13:37:46 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 3 Fabio Valentini 2021-12-13 15:42:33 UTC

Thanks for the review!

Comment 4 Gwyn Ciesla 2021-12-13 16:24:39 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-base64ct

Comment 5 Fabio Valentini 2021-12-13 17:15:37 UTC

Built and submitted for all Fedora branches:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-c08dc4beeb
https://bodhi.fedoraproject.org/updates/FEDORA-2021-0ca3f75e15
https://bodhi.fedoraproject.org/updates/FEDORA-2021-55dddfadaf