Bug 2031162 - Review Request: rust-base64ct - Pure Rust, constant-time implementation of Base64 (RFC 4648)
Summary: Review Request: rust-base64ct - Pure Rust, constant-time implementation of Ba...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Trystram
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-12-10 16:27 UTC by Fabio Valentini
Modified: 2021-12-13 17:15 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-12-13 17:15:37 UTC
Type: ---
Embargoed:
jbtrystram: fedora-review+

Attachments (Terms of Use)

Description Fabio Valentini 2021-12-10 16:27:38 UTC 
Spec URL: https://decathorpe.fedorapeople.org/rust-base64ct.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-base64ct-1.3.0-1.fc35.src.rpm

Description:
Pure Rust implementation of Base64 (RFC 4648) which avoids any usages of data-
dependent branches/LUTs and thereby provides portable "best effort" constant-
time operation and embedded-friendly no_std support.

Fedora Account System Username: decathorpe
Comment 1 Fabio Valentini 2021-12-10 16:27:41 UTC 
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=79794322
Comment 2 Trystram 2021-12-13 13:37:46 UTC 
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.
Comment 3 Fabio Valentini 2021-12-13 15:42:33 UTC 
Thanks for the review!
Comment 4 Gwyn Ciesla 2021-12-13 16:24:39 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-base64ct
Comment 5 Fabio Valentini 2021-12-13 17:15:37 UTC 
Built and submitted for all Fedora branches:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-c08dc4beeb
https://bodhi.fedoraproject.org/updates/FEDORA-2021-0ca3f75e15
https://bodhi.fedoraproject.org/updates/FEDORA-2021-55dddfadaf
Note You need to log in before you can comment on or make changes to this bug.