Bug 2031584
| Summary: | Review Request: golang-github-gohugoio-locales - Go library for locales | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | W. Michael Petullo <mike> |
| Component: | Package Review | Assignee: | Maxwell G <maxwell> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | maxwell, package-review |
| Target Milestone: | --- | Flags: | maxwell:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-03-21 19:34:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1930952, 2031585 | ||
|
Description
W. Michael Petullo
2021-12-13 02:21:33 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-locales.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-locales-0.14.0-1.fc35.src.rpm Rebuilt using go2rpm. > Patch0: locales-0.14.0-remove-broken-tests.patch > [...] > %patch0 -p1 Instead of completely deleting the test files, you should change `%gocheck` to `%gocheck -d eu`[1]. [1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_running_the_unit_tests_gocheck > %files > %license LICENSE > %doc README.md This isn't necessary. Besides that, this package looks good to me. Spec URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-locales.spec SRPM URL: golang-github-gohugoio-locales-0.14.0-1.fc35.src.rpm Revised to use "%gocheck -d eu" and remove "%files". (In reply to W. Michael Petullo from comment #3) > Spec URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-locales.spec > SRPM URL: golang-github-gohugoio-locales-0.14.0-1.fc35.src.rpm Fixing URLs for Fedora Review: Spec URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-locales.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-locales-0.14.0-1.fc35.src.rpm I am not going to go through the whole fedora-review template, as this package uses go2rpm. - The specfile is sane. - License is correct - Builds successfully in mock - No rpmlint errors - %check section passes - The latest version is packaged - The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - Add package to release-monitoring.org - Add package to Koschei. - Give go-sig privileges on package - Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. Thanks! (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-gohugoio-locales FEDORA-2022-8ac2de9a56 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8ac2de9a56 FEDORA-2022-8ac2de9a56 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-0f7892698f has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-0f7892698f FEDORA-2022-399c44c608 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-399c44c608 FEDORA-2022-0f7892698f has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-0f7892698f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-0f7892698f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-399c44c608 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-399c44c608 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-399c44c608 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-399c44c608 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-0f7892698f has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. |