Bug 2031584 - Review Request: golang-github-gohugoio-locales - Go library for locales
Summary: Review Request: golang-github-gohugoio-locales - Go library for locales
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Maxwell G
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1930952 2031585
TreeView+ depends on / blocked
 
Reported: 2021-12-13 02:21 UTC by W. Michael Petullo
Modified: 2022-03-30 01:28 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-21 19:34:10 UTC
Type: ---
Embargoed:
maxwell: fedora-review+


Attachments (Terms of Use)

Description W. Michael Petullo 2021-12-13 02:21:33 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-locales.spec
SRPM URL: golang-github-gohugoio-locales-0.14.0-1.fc35.src.rpm
Description:
Locales is a set of locales generated from the Unicode CLDR Project
which can be used independently or within an i18n package; these were
built for use with, but not exclusive to, Universal Translator.

This package is required to build the recent releases of Hugo.

Fedora Account System Username: mikep

Comment 2 Maxwell G 2022-03-16 22:08:04 UTC
> Patch0:         locales-0.14.0-remove-broken-tests.patch
> [...]
> %patch0 -p1

Instead of completely deleting the test files, you should change `%gocheck` to `%gocheck -d eu`[1].

[1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_running_the_unit_tests_gocheck

> %files
> %license LICENSE
> %doc README.md

This isn't necessary.

Besides that, this package looks good to me.

Comment 3 W. Michael Petullo 2022-03-18 02:55:49 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-locales.spec
SRPM URL: golang-github-gohugoio-locales-0.14.0-1.fc35.src.rpm

Revised to use "%gocheck -d eu" and remove "%files".

Comment 4 Maxwell G 2022-03-19 19:11:28 UTC
(In reply to W. Michael Petullo from comment #3)
> Spec URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-locales.spec
> SRPM URL: golang-github-gohugoio-locales-0.14.0-1.fc35.src.rpm

Fixing URLs for Fedora Review:

Spec URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-locales.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-locales-0.14.0-1.fc35.src.rpm

Comment 5 Maxwell G 2022-03-19 19:25:04 UTC
I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- The specfile is sane.
- License is correct
- Builds successfully in mock
- No rpmlint errors
- %check section passes
- The latest version is packaged
- The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- Add package to release-monitoring.org
- Add package to Koschei.
- Give go-sig privileges on package
- Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket.

Thanks!

Comment 6 Gwyn Ciesla 2022-03-21 18:32:39 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-gohugoio-locales

Comment 7 Fedora Update System 2022-03-21 19:31:35 UTC
FEDORA-2022-8ac2de9a56 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8ac2de9a56

Comment 8 Fedora Update System 2022-03-21 19:34:10 UTC
FEDORA-2022-8ac2de9a56 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2022-03-21 20:20:17 UTC
FEDORA-2022-0f7892698f has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-0f7892698f

Comment 10 Fedora Update System 2022-03-21 20:50:37 UTC
FEDORA-2022-399c44c608 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-399c44c608

Comment 11 Fedora Update System 2022-03-22 04:14:24 UTC
FEDORA-2022-0f7892698f has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-0f7892698f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-0f7892698f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-03-22 17:54:39 UTC
FEDORA-2022-399c44c608 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-399c44c608 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-399c44c608

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-03-26 15:28:38 UTC
FEDORA-2022-399c44c608 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2022-03-30 01:28:26 UTC
FEDORA-2022-0f7892698f has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.