Bug 2031585
| Summary: | Review Request: golang-github-gohugoio-localescompressed - Go library for compressed locales | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | W. Michael Petullo <mike> |
| Component: | Package Review | Assignee: | Fabio Alessandro Locati <me> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jun.miao, maxwell, me, package-review |
| Target Milestone: | --- | Flags: | me:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-04-19 19:29:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2031584 | ||
| Bug Blocks: | 1930952 | ||
|
Description
W. Michael Petullo
2021-12-13 02:21:35 UTC
jmiao@fedora35:Bug2031585$ koji build --scratch rawhide golang-github-gohugoio-localescompressed-0.14.0-1.fc35.src.rpm Uploading srpm: golang-github-gohugoio-localescompressed-0.14.0-1.fc35.src.rpm [====================================] 100% 00:01:04 24.23 MiB 385.49 KiB/sec Created task: 79911840 Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=79911840 Watching tasks (this may be safely interrupted)... 79911840 build (rawhide, golang-github-gohugoio-localescompressed-0.14.0-1.fc35.src.rpm): free 79911840 build (rawhide, golang-github-gohugoio-localescompressed-0.14.0-1.fc35.src.rpm): free -> open (buildvm-s390x-18.s390.fedoraproject.org) 79911873 rebuildSRPM (noarch): free 79911873 rebuildSRPM (noarch): free -> open (buildvm-s390x-18.s390.fedoraproject.org) 79911873 rebuildSRPM (noarch): open (buildvm-s390x-18.s390.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 79911955 buildArch (golang-github-gohugoio-localescompressed-0.14.0-1.fc36.src.rpm, armv7hl): open (buildvm-a32-06.iad2.fedoraproject.org) 79911956 buildArch (golang-github-gohugoio-localescompressed-0.14.0-1.fc36.src.rpm, i686): free 79911957 buildArch (golang-github-gohugoio-localescompressed-0.14.0-1.fc36.src.rpm, x86_64): free 79911959 buildArch (golang-github-gohugoio-localescompressed-0.14.0-1.fc36.src.rpm, ppc64le): open (buildvm-ppc64le-14.iad2.fedoraproject.org) 79911960 buildArch (golang-github-gohugoio-localescompressed-0.14.0-1.fc36.src.rpm, s390x): open (buildvm-s390x-23.s390.fedoraproject.org) 79911958 buildArch (golang-github-gohugoio-localescompressed-0.14.0-1.fc36.src.rpm, aarch64): open (buildvm-a64-18.iad2.fedoraproject.org) 79911956 buildArch (golang-github-gohugoio-localescompressed-0.14.0-1.fc36.src.rpm, i686): free -> open (buildvm-x86-07.iad2.fedoraproject.org) 79911957 buildArch (golang-github-gohugoio-localescompressed-0.14.0-1.fc36.src.rpm, x86_64): free -> open (buildvm-x86-05.iad2.fedoraproject.org) 79911960 buildArch (golang-github-gohugoio-localescompressed-0.14.0-1.fc36.src.rpm, s390x): open (buildvm-s390x-23.s390.fedoraproject.org) -> FAILED: BuildError: error building package (arch s390x), mock exited with status 1; see build.log or root.log for more information Relevant logs: https://kojipkgs.fedoraproject.org/work/tasks/1960/79911960/mock_output.log https://kojipkgs.fedoraproject.org/work/tasks/1960/79911960/hw_info.log https://kojipkgs.fedoraproject.org/work/tasks/1960/79911960/state.log https://kojipkgs.fedoraproject.org/work/tasks/1960/79911960/build.log https://kojipkgs.fedoraproject.org/work/tasks/1960/79911960/root.log 0 free 6 open 1 done 1 failed
please add %build in the spec. because there is some build warnning
jmiao@fedora35:Bug2031585$ rpmlint golang-github-gohugoio-localescompressed.spec golang-github-gohugoio-localescompressed-0.14.0-1.fc35.src.rpm
=================================================================== rpmlint session starts ===================================================================
rpmlint: 2.1.0
configuration:
/usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/licenses.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 2
golang-github-gohugoio-localescompressed.spec: W: no-%build-section
golang-github-gohugoio-localescompressed.spec: W: no-%build-section
==================================== 1 packages and 1 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 1.2 s ====================================
jmiao@fedora35:Bug2031585$
Please regenerate this specfile with go2rpm. There are a couple issues (missing build dependencies and no `%godocs`) with this specfile that go2rpm will fix. You should do the same for your other go review requests. Thanks, Maxwell Spec URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-localescompressed.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-localescompressed-0.14.0-1.fc35.src.rpm Rebuilt using go2rpm. 1. There is 0.15.0 available 2. It could make sense to use latest go2rpm (1.6.0) Then I think we can start this review, which should be fairly straightforward Spec URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-localescompressed.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-localescompressed-1.0.1-1.fc35.src.rpm Updated to 1.0.1 and rebuilt using go2rpm 1.6.1. The package is mostly ok. Only problem I see is that this SPEC file is building (and shipping) the `gen` binary, whose only use is to build the source itself. Please drop it. Spec URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-localescompressed.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-localescompressed-1.0.1-1.fc35.src.rpm This revision drops gen from the package. In doing so, it also turns off debug_package, as there is nothing to debug. go2rpm package, fedora-review is correct: - The specfile is sane. - License is correct - Builds successfully in mock - No rpmlint errors - %check section passes - The latest version is packaged - The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - Add package to release-monitoring.org - Add package to Koschei. - Give go-sig privileges on package - Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. (rhbz#BUG_ID) Thanks! PS: My understanding is that you are aiming to package the latest version of hugo. Are there any other Review that are still pending/need a reviewer? (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-gohugoio-localescompressed FEDORA-2022-0420511bc2 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-0420511bc2 FEDORA-2022-0420511bc2 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-d0acda7409 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d0acda7409 FEDORA-2022-d2c85ea42d has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d2c85ea42d FEDORA-2022-d0acda7409 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-d0acda7409 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d0acda7409 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-d2c85ea42d has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-d2c85ea42d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d2c85ea42d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-d2c85ea42d has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-d0acda7409 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. |