Bug 2031925

Summary:	Review Request: rust-password-hash - Traits which describe password hashing algorithms
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Davide Cavalca <davide>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	davide, package-review
Target Milestone:	---	Flags:	davide: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-01-05 22:47:10 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2034218, 2034225

Description Fabio Valentini 2021-12-13 17:35:14 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-password-hash.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-password-hash-0.3.2-1.fc35.src.rpm

Description:
Traits which describe the functionality of password hashing algorithms, as well
as a `no_std`-friendly implementation of the PHC string format (a well-defined
subset of the Modular Crypt Format a.k.a. MCF).

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2021-12-13 17:35:17 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=79937212

Comment 2 Davide Cavalca 2021-12-31 08:16:13 UTC

Taking this review

Comment 3 Davide Cavalca 2021-12-31 08:18:51 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT or ASL 2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 4 Fabio Valentini 2021-12-31 11:34:35 UTC

Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/40340
https://pagure.io/releng/fedora-scm-requests/issue/40341
https://pagure.io/releng/fedora-scm-requests/issue/40342

Comment 5 Gwyn Ciesla 2022-01-04 15:22:22 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-password-hash

Comment 6 Fabio Valentini 2022-01-05 22:47:10 UTC

Built for all current Fedora branches:
https://bodhi.fedoraproject.org/updates/FEDORA-2022-c5fea33efb
https://bodhi.fedoraproject.org/updates/FEDORA-2022-3d92ea5225
https://bodhi.fedoraproject.org/updates/FEDORA-2022-de992cd330