Bug 2031925 - Review Request: rust-password-hash - Traits which describe password hashing algorithms
Summary: Review Request: rust-password-hash - Traits which describe password hashing a...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2034218 2034225
TreeView+ depends on / blocked
 
Reported: 2021-12-13 17:35 UTC by Fabio Valentini
Modified: 2022-01-05 22:47 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-01-05 22:47:10 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2021-12-13 17:35:14 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-password-hash.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-password-hash-0.3.2-1.fc35.src.rpm

Description:
Traits which describe the functionality of password hashing algorithms, as well
as a `no_std`-friendly implementation of the PHC string format (a well-defined
subset of the Modular Crypt Format a.k.a. MCF).

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2021-12-13 17:35:17 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=79937212

Comment 2 Davide Cavalca 2021-12-31 08:16:13 UTC
Taking this review

Comment 3 Davide Cavalca 2021-12-31 08:18:51 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT or ASL 2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 5 Gwyn Ciesla 2022-01-04 15:22:22 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-password-hash


Note You need to log in before you can comment on or make changes to this bug.